Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-26 Thread John Groves
On 24/02/26 04:56PM, Jonathan Cameron wrote: > On Mon, 26 Feb 2024 10:44:43 -0600 > John Groves wrote: > > > On 24/02/26 12:39PM, Jonathan Cameron wrote: > > > On Fri, 23 Feb 2024 11:41:51 -0600 > > > John Groves wrote: > > > > > > > Add uapi include file for famfs. The famfs user space uses

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-26 Thread Jonathan Cameron
On Mon, 26 Feb 2024 10:44:43 -0600 John Groves wrote: > On 24/02/26 12:39PM, Jonathan Cameron wrote: > > On Fri, 23 Feb 2024 11:41:51 -0600 > > John Groves wrote: > > > > > Add uapi include file for famfs. The famfs user space uses ioctl on > > > individual files to pass in mapping informatio

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-26 Thread John Groves
On 24/02/26 12:39PM, Jonathan Cameron wrote: > On Fri, 23 Feb 2024 11:41:51 -0600 > John Groves wrote: > > > Add uapi include file for famfs. The famfs user space uses ioctl on > > individual files to pass in mapping information and file size. This > > would be hard to do via sysfs or other means

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-26 Thread Jonathan Cameron
On Fri, 23 Feb 2024 11:41:51 -0600 John Groves wrote: > Add uapi include file for famfs. The famfs user space uses ioctl on > individual files to pass in mapping information and file size. This > would be hard to do via sysfs or other means, since it's > file-specific. > > Signed-off-by: John Gr

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-24 Thread Randy Dunlap
On 2/24/24 15:32, John Groves wrote: > On 24/02/23 07:27PM, Randy Dunlap wrote: >> Hi John, >> >> On 2/23/24 18:23, John Groves wrote: > + > +#define FAMFSIOC_MAGIC 'u' This 'u' value should be documented in Documentation/userspace-api/ioctl/ioctl-number.rst. and if p

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-24 Thread John Groves
On 24/02/23 07:27PM, Randy Dunlap wrote: > Hi John, > > On 2/23/24 18:23, John Groves wrote: > >>> + > >>> +#define FAMFSIOC_MAGIC 'u' > >> This 'u' value should be documented in > >> Documentation/userspace-api/ioctl/ioctl-number.rst. > >> > >> and if possible, you might want to use values like 0

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-23 Thread Randy Dunlap
Hi John, On 2/23/24 18:23, John Groves wrote: >>> + >>> +#define FAMFSIOC_MAGIC 'u' >> This 'u' value should be documented in >> Documentation/userspace-api/ioctl/ioctl-number.rst. >> >> and if possible, you might want to use values like 0x5x or 0x8x >> that don't conflict with the ioctl numbers t

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-23 Thread John Groves
On 24/02/23 05:39PM, Randy Dunlap wrote: > Hi-- > > On 2/23/24 09:41, John Groves wrote: > > Add uapi include file for famfs. The famfs user space uses ioctl on > > individual files to pass in mapping information and file size. This > > would be hard to do via sysfs or other means, since it's > >

Re: [RFC PATCH 07/20] famfs: Add include/linux/famfs_ioctl.h

2024-02-23 Thread Randy Dunlap
Hi-- On 2/23/24 09:41, John Groves wrote: > Add uapi include file for famfs. The famfs user space uses ioctl on > individual files to pass in mapping information and file size. This > would be hard to do via sysfs or other means, since it's > file-specific. > > Signed-off-by: John Groves > --- >