Re: [RESEND PATCH] watchdog: ni7018_wdt: Add NIC7018 watchdog driver

2016-11-15 Thread Hui Chun Ong
Hi Guenter, I'll remove all the attributes for this patch and post a separate patch with the attributes and explanation for the need and usage of those attributes. rgds Hui Chun On Fri, 2016-10-28 at 10:25 -0700, Guenter Roeck wrote: > Hi, > > On Fri, Oct 28, 2016 at 03:51:07PM +0800, Hui Chun

Re: [RESEND PATCH] watchdog: ni7018_wdt: Add NIC7018 watchdog driver

2016-10-28 Thread Guenter Roeck
Hi, On Fri, Oct 28, 2016 at 03:51:07PM +0800, Hui Chun Ong wrote: > Add support for the watchdog timer on PXI Embedded Controller. > > Signed-off-by: Hui Chun Ong The problem with your patch are the non-standard attributes it introduces. +static WDT_ATTR(enable_reset, WDT_CTRL, WDT_CTRL_RESET_