Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-27 Thread Nicolin Chen
On Thu, Sep 27, 2018 at 03:06:20PM -0700, Guenter Roeck wrote: > I am quite sure I asked to use kstrtobool(). Did that get lost or do you have > some reason to not use it ? > > I can understand if you don't want to change ina3221_is_enable() to > ina3221_is_enabled(), since that is POV, but I do

Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-27 Thread Guenter Roeck
On Thu, Sep 27, 2018 at 01:54:06PM -0700, Nicolin Chen wrote: > An ina3221 chip has three input ports. Each port is used > to measure the voltage and current of its input source. > > The DT binding now has defined bindings for their input > sources, so the driver should read these information and