Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-20 Thread Waiman Long
On 03/20/2018 05:14 PM, Tejun Heo wrote: > Hello, > > On Tue, Mar 20, 2018 at 04:53:37PM -0400, Waiman Long wrote: >> ASAIK for v2, when cpuset.cpus is empty, cpuset.effective_cpus will show >> all the cpus available from the parent. It is a different behavior from >> v1. So do we still need a cpus

Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-20 Thread Tejun Heo
Hello, On Tue, Mar 20, 2018 at 04:53:37PM -0400, Waiman Long wrote: > ASAIK for v2, when cpuset.cpus is empty, cpuset.effective_cpus will show > all the cpus available from the parent. It is a different behavior from > v1. So do we still need a cpuset.cpus_available? Heh, you're right. Let's for

Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-20 Thread Waiman Long
On 03/20/2018 04:10 PM, Tejun Heo wrote: > Hello, Waiman. > > On Tue, Mar 20, 2018 at 09:51:20AM -0400, Waiman Long wrote: + It lists the onlined CPUs that are actually allowed to be + used by tasks within the current cgroup. It is a subset of + "cpuset.cpus". Its value will be a

Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-20 Thread Tejun Heo
Hello, Waiman. On Tue, Mar 20, 2018 at 09:51:20AM -0400, Waiman Long wrote: > >> + It lists the onlined CPUs that are actually allowed to be > >> + used by tasks within the current cgroup. It is a subset of > >> + "cpuset.cpus". Its value will be affected by CPU hotplug > >> + events. > > Can

Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-20 Thread Waiman Long
On 03/19/2018 11:59 AM, Tejun Heo wrote: > Hello, Waiman. > > This looks great. A couple nitpicks below. > >> + 5-3. Cpuset >> + 5.3-1. Cpuset Interface Files > Can we put cpuset below pid? It feels weird to break up cpu, memory > and io as they represent the three major resources and a

Re: [PATCH v5 1/2] cpuset: Enable cpuset controller in default hierarchy

2018-03-19 Thread Tejun Heo
Hello, Waiman. This looks great. A couple nitpicks below. > + 5-3. Cpuset > + 5.3-1. Cpuset Interface Files Can we put cpuset below pid? It feels weird to break up cpu, memory and io as they represent the three major resources and are in a similar fashion. > + cpuset.effective_cpus