Re: [PATCH v4 4/7] cgroup: cgroup v2 freezer

2018-12-03 Thread Roman Gushchin
On Mon, Dec 03, 2018 at 03:47:18PM +0100, Oleg Nesterov wrote: > To be honest, I fail to understand this patch. At least after a quick glance, > I will try to read it again tomorrow but so far I do not even understand the > desired semantics wrt signals/ptrace. > > On 11/30, Roman Gushchin wrote:

Re: [PATCH v4 4/7] cgroup: cgroup v2 freezer

2018-12-03 Thread Oleg Nesterov
On 11/30, Roman Gushchin wrote: > > void recalc_sigpending(void) > { > if (!recalc_sigpending_tsk(current) && !freezing(current) && > - !klp_patch_pending(current)) > + !klp_patch_pending(current) && !cgroup_task_frozen(current)) I must have missed something... but shouldn'

Re: [PATCH v4 4/7] cgroup: cgroup v2 freezer

2018-12-03 Thread Oleg Nesterov
On 11/30, Roman Gushchin wrote: > > +void cgroup_enter_frozen(void) > +{ > + if (!current->frozen) { > + struct cgroup *cgrp; > + > + spin_lock_irq(&css_set_lock); > + current->frozen = true; > + cgrp = task_dfl_cgroup(current); > + cg

Re: [PATCH v4 4/7] cgroup: cgroup v2 freezer

2018-12-03 Thread Oleg Nesterov
To be honest, I fail to understand this patch. At least after a quick glance, I will try to read it again tomorrow but so far I do not even understand the desired semantics wrt signals/ptrace. On 11/30, Roman Gushchin wrote: > > @@ -368,6 +369,8 @@ static inline int signal_pending_state(long state