Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-07 Thread Rong Xu
On Mon, Oct 7, 2024 at 11:33 AM Miguel Ojeda wrote: > > On Mon, Oct 7, 2024 at 8:04 PM Rong Xu wrote: > > > > I removed the "code-block" directives from the rst files, > > and used "::" suggested by Jonathan. The rst files themselves are now > > I think it was Mike. Sorry for mixing up the names

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-07 Thread Miguel Ojeda
On Mon, Oct 7, 2024 at 8:04 PM Rong Xu wrote: > > I removed the "code-block" directives from the rst files, > and used "::" suggested by Jonathan. The rst files themselves are now I think it was Mike. > (1) The text that was previously in code-block no longer indents. It aligns > with the

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-07 Thread Rong Xu
I removed the "code-block" directives from the rst files, and used "::" suggested by Jonathan. The rst files themselves are now easier to read in vi. However, the rendered HTML output has some differences: (1) The text that was previously in code-block no longer indents. It aligns with the p

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-05 Thread Jonathan Corbet
Kees Cook writes: > The tradition in kernel .rst is to do this with the trailing "::", e.g.: > > +Configure the kernel with:: > + > + CONFIG_AUTOFDO_CLANG=y > > This loses the language-specific highlighting when rendered. Perhaps the > "::" extension can be further extended? > > +Configure th

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-05 Thread Peter Zijlstra
On Fri, Oct 04, 2024 at 02:23:45PM -0700, Justin Stitt wrote: > On Fri, Oct 4, 2024 at 11:29 AM Peter Zijlstra wrote: > > > > On Fri, Oct 04, 2024 at 11:10:04AM -0700, Kees Cook wrote: > > > > > +Configure the kernel with::(make) > > > + > > > + CONFIG_AUTOFDO_CLANG=y > > > > > > Then we could

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Justin Stitt
On Fri, Oct 4, 2024 at 11:29 AM Peter Zijlstra wrote: > > On Fri, Oct 04, 2024 at 11:10:04AM -0700, Kees Cook wrote: > > > +Configure the kernel with::(make) > > + > > + CONFIG_AUTOFDO_CLANG=y > > > > Then we could avoid the extra 2 lines but still gain the rendered language > > highlights? >

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Peter Zijlstra
On Fri, Oct 04, 2024 at 11:10:04AM -0700, Kees Cook wrote: > +Configure the kernel with::(make) > + > + CONFIG_AUTOFDO_CLANG=y > > Then we could avoid the extra 2 lines but still gain the rendered language > highlights? The whole double-colon thing is already a pain to read; you're making it

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Kees Cook
On Thu, Oct 03, 2024 at 05:41:43PM +0200, Peter Zijlstra wrote: > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > > +Preparation > > +=== > > + > > +Configure the kernel with: > > + > > + .. code-block:: make > > + > > + CONFIG_AUTOFDO_CLANG=y > > + > > + > [...] > > +

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Rong Xu
On Fri, Oct 4, 2024 at 9:38 AM Mike Rapoport wrote: > > On Fri, Oct 04, 2024 at 09:28:36AM -0700, Rong Xu wrote: > > On Thu, Oct 3, 2024 at 11:09 PM Mike Rapoport wrote: > > > > > > On Thu, Oct 03, 2024 at 11:20:17AM -0700, Rong Xu wrote: > > > > Writing the doc with all these code-blocks was not

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Mike Rapoport
On Fri, Oct 04, 2024 at 09:28:36AM -0700, Rong Xu wrote: > On Thu, Oct 3, 2024 at 11:09 PM Mike Rapoport wrote: > > > > On Thu, Oct 03, 2024 at 11:20:17AM -0700, Rong Xu wrote: > > > Writing the doc with all these code-blocks was not fun either. > > > We are happy to change if there is a better wa

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-04 Thread Rong Xu
On Thu, Oct 3, 2024 at 11:09 PM Mike Rapoport wrote: > > On Thu, Oct 03, 2024 at 11:20:17AM -0700, Rong Xu wrote: > > Writing the doc with all these code-blocks was not fun either. > > We are happy to change if there is a better way for this. > > > > -Rong > > > > On Thu, Oct 3, 2024 at 9:13 AM Pe

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Mike Rapoport
On Thu, Oct 03, 2024 at 11:20:17AM -0700, Rong Xu wrote: > Writing the doc with all these code-blocks was not fun either. > We are happy to change if there is a better way for this. > > -Rong > > On Thu, Oct 3, 2024 at 9:13 AM Peter Zijlstra wrote: > > > > On Thu, Oct 03, 2024 at 09:11:34AM -070

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Rong Xu
Writing the doc with all these code-blocks was not fun either. We are happy to change if there is a better way for this. -Rong On Thu, Oct 3, 2024 at 9:13 AM Peter Zijlstra wrote: > > On Thu, Oct 03, 2024 at 09:11:34AM -0700, Nick Desaulniers wrote: > > > > It makes it absolute crap for all of u

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2024 at 09:11:34AM -0700, Nick Desaulniers wrote: > > It makes it absolute crap for all of us who 'render' text documents > > using less or vi. > > "It hurts when I punch myself in the face." Weirdly enough I have a job that entails staring at text documents in text editors all d

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Nick Desaulniers
On Thu, Oct 3, 2024 at 9:03 AM Peter Zijlstra wrote: > > On Thu, Oct 03, 2024 at 08:51:51AM -0700, Nick Desaulniers wrote: > > On Thu, Oct 3, 2024 at 8:42 AM Peter Zijlstra wrote: > > > > > > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > > > > +6) Rebuild the kernel using the AutoFDO

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2024 at 08:51:51AM -0700, Nick Desaulniers wrote: > On Thu, Oct 3, 2024 at 8:42 AM Peter Zijlstra wrote: > > > > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > > > +6) Rebuild the kernel using the AutoFDO profile file with the same > > > config as step 1, > > > +(N

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Nick Desaulniers
On Thu, Oct 3, 2024 at 8:42 AM Peter Zijlstra wrote: > > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > > +6) Rebuild the kernel using the AutoFDO profile file with the same config > > as step 1, > > +(Note CONFIG_AUTOFDO_CLANG needs to be enabled): > > + > > + .. code-block:

Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

2024-10-03 Thread Peter Zijlstra
On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > +Preparation > +=== > + > +Configure the kernel with: > + > + .. code-block:: make > + > + CONFIG_AUTOFDO_CLANG=y > + > +Customization > += > + > +You can enable or disable AutoFDO build for individual file and di