Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-12-10 Thread Will Deacon
On Mon, Dec 09, 2024 at 03:51:34PM -0800, Yabin Cui wrote: > On Mon, Dec 9, 2024 at 10:56 AM Will Deacon wrote: > > > > (Aside: please try to avoid top-posting on the public lists as it messes up > > the flow of conversation; I'll try to piece this back together.) > > > > On Mon, Dec 09, 2024 at

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-12-09 Thread Yabin Cui
On Mon, Dec 9, 2024 at 10:56 AM Will Deacon wrote: > > (Aside: please try to avoid top-posting on the public lists as it messes up > the flow of conversation; I'll try to piece this back together.) > > On Mon, Dec 09, 2024 at 09:30:50AM -0800, Rong Xu wrote: > > On Mon, Dec 9, 2024 at 8:20 AM Wil

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-12-09 Thread Will Deacon
(Aside: please try to avoid top-posting on the public lists as it messes up the flow of conversation; I'll try to piece this back together.) On Mon, Dec 09, 2024 at 09:30:50AM -0800, Rong Xu wrote: > On Mon, Dec 9, 2024 at 8:20 AM Will Deacon wrote: > > On Mon, Nov 18, 2024 at 02:25:40PM -0800, Y

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-12-09 Thread Rong Xu
Enabling an AutoFDO build requires users to explicitly set CONFIG_AUTOFDO_CLANG. The support code is in Commit 315ad8780a129e82 (kbuild: Add AutoFDO support for Clang build). The CONFIG_AUTOFDO_CLANG config, even if selected by the user, will not be enabled unless ARCH_SUPPORTS_AUTOFDO_CLANG is pr

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-12-09 Thread Will Deacon
On Mon, Nov 18, 2024 at 02:25:40PM -0800, Yabin Cui wrote: > Select ARCH_SUPPORTS_AUTOFDO_CLANG to allow AUTOFDO_CLANG to be > selected. > > On ARM64, ETM traces can be recorded and converted to AutoFDO profiles. > Experiments on Android show 4% improvement in cold app startup time > and 13% impro

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-20 Thread Kees Cook
On Mon, Nov 18, 2024 at 02:25:40PM -0800, Yabin Cui wrote: > Select ARCH_SUPPORTS_AUTOFDO_CLANG to allow AUTOFDO_CLANG to be > selected. > > On ARM64, ETM traces can be recorded and converted to AutoFDO profiles. > Experiments on Android show 4% improvement in cold app startup time > and 13% impro

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-20 Thread George Burgess
We've used ETM in ChromeOS for a while now. Hardware requirements make it unfortunately less ubiquitous than LBR, but: - we first launched it on 5.15, - it's still humming along nicely today on 6.6, so: Tested-by: George Burgess IV IIRC, with a baseline of "using x86_64 AFDO profiles on ARM kern

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-19 Thread Yabin Cui
Add George from ChromeOS. On Mon, Nov 18, 2024 at 3:49 PM Rong Xu wrote: > > This patch looks good to me. > > I assume the profile format change in the Android doc will be submitted soon. > Since "extbinary" is a superset of "binary", using the "extbinary" > format profile > in Android shouldn't

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-18 Thread Rong Xu
This patch looks good to me. I assume the profile format change in the Android doc will be submitted soon. Since "extbinary" is a superset of "binary", using the "extbinary" format profile in Android shouldn't cause any compatibility issues. Reviewed-by: Rong Xu -Rong On Mon, Nov 18, 2024 at 2