On Mon, 3 Mar 2025 19:53:44 -0800 Mina Almasry wrote:
> > Upper devices and BPF access is covered I think, by the skbuff checks.
> > But I think we missed adding a check in validate_xmit_skb() to protect
> > the xmit paths of HW|virt drivers. You can try to add a TC rule which
> > forwards all traf
On Mon, Mar 3, 2025 at 4:29 PM Jakub Kicinski wrote:
>
> On Fri, 28 Feb 2025 17:53:24 -0800 Mina Almasry wrote:
> > On Fri, Feb 28, 2025 at 4:43 PM Jakub Kicinski wrote:
> > > On Thu, 27 Feb 2025 04:12:08 + Mina Almasry wrote:
> > > > + if (!skb_frags_readable(skb) && !dev->netmem_tx)
> >
On Fri, 28 Feb 2025 17:53:24 -0800 Mina Almasry wrote:
> On Fri, Feb 28, 2025 at 4:43 PM Jakub Kicinski wrote:
> > On Thu, 27 Feb 2025 04:12:08 + Mina Almasry wrote:
> > > + if (!skb_frags_readable(skb) && !dev->netmem_tx)
> >
> > How do you know it's for _this_ device tho?
>
> Mayb
On Fri, Feb 28, 2025 at 4:43 PM Jakub Kicinski wrote:
>
> On Thu, 27 Feb 2025 04:12:08 + Mina Almasry wrote:
> > + if (!skb_frags_readable(skb) && !dev->netmem_tx)
>
> How do you know it's for _this_ device tho?
Maybe a noob question, but how do we end up here with an skb that is
not targ
On Thu, 27 Feb 2025 04:12:08 + Mina Almasry wrote:
> + if (!skb_frags_readable(skb) && !dev->netmem_tx)
How do you know it's for _this_ device tho?
The driver doesn't seem to check the DMA mapping belongs to it either.
Remind me, how do we prevent the unreadable skbs from getting into the
