Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-26 Thread David Ahern
On 2/25/25 11:54 AM, Mina Almasry wrote: > > Will do, although I think maybe I'll add that comment above the > refcount_t definition in net_devmem_dmabuf_binding, if that's OK with > you. That was meant to explain how the refcounting on the binding > works. > That is fine, I just think the lifec

Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-25 Thread Mina Almasry
On Tue, Feb 25, 2025 at 10:03 AM David Ahern wrote: > > On 2/25/25 10:41 AM, Mina Almasry wrote: > > On Tue, Feb 25, 2025 at 5:04 AM Paolo Abeni wrote: > >> > >> On 2/22/25 8:15 PM, Mina Almasry wrote: > >> [...] > >>> @@ -119,6 +122,13 @@ void net_devmem_unbind_dmabuf(struct > >>> net_devmem_dm

Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-25 Thread David Ahern
On 2/25/25 10:41 AM, Mina Almasry wrote: > On Tue, Feb 25, 2025 at 5:04 AM Paolo Abeni wrote: >> >> On 2/22/25 8:15 PM, Mina Almasry wrote: >> [...] >>> @@ -119,6 +122,13 @@ void net_devmem_unbind_dmabuf(struct >>> net_devmem_dmabuf_binding *binding) >>> unsigned long xa_idx; >>> unsi

Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-25 Thread Mina Almasry
On Tue, Feb 25, 2025 at 5:04 AM Paolo Abeni wrote: > > On 2/22/25 8:15 PM, Mina Almasry wrote: > [...] > > @@ -119,6 +122,13 @@ void net_devmem_unbind_dmabuf(struct > > net_devmem_dmabuf_binding *binding) > > unsigned long xa_idx; > > unsigned int rxq_idx; > > > > + xa_erase(&net_

Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-25 Thread Paolo Abeni
On 2/22/25 8:15 PM, Mina Almasry wrote: [...] > @@ -119,6 +122,13 @@ void net_devmem_unbind_dmabuf(struct > net_devmem_dmabuf_binding *binding) > unsigned long xa_idx; > unsigned int rxq_idx; > > + xa_erase(&net_devmem_dmabuf_bindings, binding->id); > + > + /* Ensure no tx ne

Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path

2025-02-24 Thread Stanislav Fomichev
On 02/22, Mina Almasry wrote: > Augment dmabuf binding to be able to handle TX. Additional to all the RX > binding, we also create tx_vec needed for the TX path. > > Provide API for sendmsg to be able to send dmabufs bound to this device: > > - Provide a new dmabuf_tx_cmsg which includes the dmab