Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/20/25 01:46, Mina Almasry wrote: On Wed, Feb 19, 2025 at 2:40 PM Pavel Begunkov wrote: On 2/17/25 23:26, Mina Almasry wrote: On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: ... It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and I'm guessing increasing skb->cb si

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On Wed, Feb 19, 2025 at 2:40 PM Pavel Begunkov wrote: > > On 2/17/25 23:26, Mina Almasry wrote: > > On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov > > wrote: > ... > > It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and > > I'm guessing increasing skb->cb size is not real

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/17/25 23:26, Mina Almasry wrote: On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: ... It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and I'm guessing increasing skb->cb size is not really the way to go. What I may be able to do here is stash the binding somewhere in

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: > > On 2/12/25 19:18, Mina Almasry wrote: > > On Wed, Feb 12, 2025 at 7:52 AM Pavel Begunkov > > wrote: > >> > >> On 2/10/25 21:09, Mina Almasry wrote: > >>> On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov > >>> wrote: > > On 2/3/25

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/12/25 19:18, Mina Almasry wrote: On Wed, Feb 12, 2025 at 7:52 AM Pavel Begunkov wrote: On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h inde

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On Wed, Feb 12, 2025 at 7:52 AM Pavel Begunkov wrote: > > On 2/10/25 21:09, Mina Almasry wrote: > > On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov > > wrote: > >> > >> On 2/3/25 22:39, Mina Almasry wrote: > >> ... > >>> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > >>> index bb2b

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index bb2b751d274a..3ff8f568c382 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: > > On 2/3/25 22:39, Mina Almasry wrote: > ... > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > index bb2b751d274a..3ff8f568c382 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > > @@ -1711,9 +1711,12

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

Mina Almasry wrote: > Augment dmabuf binding to be able to handle TX. Additional to all the RX > binding, we also create tx_vec needed for the TX path. > > Provide API for sendmsg to be able to send dmabufs bound to this device: > > - Provide a new dmabuf_tx_cmsg which includes the dmabuf to send

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index bb2b751d274a..3ff8f568c382 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -1711,9 +1711,12 @@ struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size, ...

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

On 2/3/25 11:39 PM, Mina Almasry wrote: > Augment dmabuf binding to be able to handle TX. Additional to all the RX > binding, we also create tx_vec needed for the TX path. > > Provide API for sendmsg to be able to send dmabufs bound to this device: > > - Provide a new dmabuf_tx_cmsg which include