Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-19 Thread Zhang Rui
On 二, 2018-03-20 at 09:38 +0800, Viresh Kumar wrote: > On 14-03-18, 13:44, Viresh Kumar wrote: > > > > I got those warnings as well, and I quietly ignored them :) > > > > I ignored the renaming part for the sake of consistency. The other > > existing > > routines for similar purpose are named as:

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-19 Thread Viresh Kumar
On 14-03-18, 13:44, Viresh Kumar wrote: > I got those warnings as well, and I quietly ignored them :) > > I ignored the renaming part for the sake of consistency. The other existing > routines for similar purpose are named as: > > thermal_cooling_device_type_show > thermal_cooling_device_max_stat

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-14 Thread Viresh Kumar
On 14-03-18, 16:01, Zhang Rui wrote: > WARNING: please write a paragraph that describes the config symbol > fully > #147: FILE: drivers/thermal/Kconfig:18: > +config THERMAL_STATISTICS > > WARNING: Consider renaming function(s) > 'thermal_cooling_device_total_trans_show' to 'total_trans_show' > #3

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-14 Thread Zhang Rui
On 二, 2018-03-13 at 15:02 +0800, Zhang Rui wrote: > Hi, Viresh, > > I will queue it for 4.17, with just one minor fix below. > I got the following warning from checkpatch.pl --- WARNING: please write a paragraph that describes the config symbol fully #147: FILE: drivers/thermal/Kconf

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-13 Thread Viresh Kumar
On 13-03-18, 15:02, Zhang Rui wrote: > Hi, Viresh, > > I will queue it for 4.17, with just one minor fix below. > > On 二, 2018-01-16 at 15:22 +0530, Viresh Kumar wrote: > > + cdev->stats = stats; > > + stats->last_time = ktime_get(); > > + stats->max_states = states; > > + cdev->stats =

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-13 Thread Zhang Rui
Hi, Viresh, I will queue it for 4.17, with just one minor fix below. On 二, 2018-01-16 at 15:22 +0530, Viresh Kumar wrote: > This extends the sysfs interface for thermal cooling devices and > exposes > some pretty useful statistics. These statistics have proven to be > quite > useful specially whi

Re: [PATCH V4] thermal: Add cooling device's statistics in sysfs

2018-03-11 Thread Viresh Kumar
On 16-01-18, 15:22, Viresh Kumar wrote: > This extends the sysfs interface for thermal cooling devices and exposes > some pretty useful statistics. These statistics have proven to be quite > useful specially while doing benchmarks related to the task scheduler, > where we want to make sure that not