Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi

2024-10-04 Thread Deepak Gupta
On Wed, Oct 02, 2024 at 05:18:36PM -0600, Shuah Khan wrote: On 10/1/24 10:06, Deepak Gupta wrote: Adds kselftest for RISC-V control flow integrity implementation for user mode. There is not a lot going on in kernel for enabling landing pad for user mode. cfi selftest are intended to be compiled

Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi

2024-10-03 Thread Edgecombe, Rick P
On Thu, 2024-10-03 at 17:04 -0600, Shuah Khan wrote: > On 10/3/24 05:03, Mark Brown wrote: > > On Wed, Oct 02, 2024 at 05:18:36PM -0600, Shuah Khan wrote: > > > On 10/1/24 10:06, Deepak Gupta wrote: > > > > > > +#ifndef __NR_prctl > > > > +#define __NR_prctl 167 > > > > +#endif > > > > > > +#ifnd

Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi

2024-10-03 Thread Shuah Khan
On 10/3/24 05:03, Mark Brown wrote: On Wed, Oct 02, 2024 at 05:18:36PM -0600, Shuah Khan wrote: On 10/1/24 10:06, Deepak Gupta wrote: +#ifndef __NR_prctl +#define __NR_prctl 167 +#endif +#ifndef __NR_map_shadow_stack +#define __NR_map_shadow_stack 453 Why do we need to define these? Sho

Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi

2024-10-03 Thread Mark Brown
On Wed, Oct 02, 2024 at 05:18:36PM -0600, Shuah Khan wrote: > On 10/1/24 10:06, Deepak Gupta wrote: > > +#ifndef __NR_prctl > > +#define __NR_prctl 167 > > +#endif > > +#ifndef __NR_map_shadow_stack > > +#define __NR_map_shadow_stack 453 > Why do we need to define these? Shouldn't including > as

Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi

2024-10-02 Thread Shuah Khan
On 10/1/24 10:06, Deepak Gupta wrote: Adds kselftest for RISC-V control flow integrity implementation for user mode. There is not a lot going on in kernel for enabling landing pad for user mode. cfi selftest are intended to be compiled with zicfilp and zicfiss enabled compiler. Thus kselftest sim