Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 02:13:00PM +0100, Markus Heiser wrote: > > Am 06.03.2017 um 11:12 schrieb Daniel Vetter : > > > Just to avoid confusion: Markus&I chatted a bit in private, and he > > volunteered to take over, and fix the few issues that need to be fixed in > > his original patch: > > - dr

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-06 Thread Markus Heiser
Am 06.03.2017 um 11:12 schrieb Daniel Vetter : > Just to avoid confusion: Markus&I chatted a bit in private, and he > volunteered to take over, and fix the few issues that need to be fixed in > his original patch: > - drop the convertsvg python fallback, since we need convert anyway > - relative

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-06 Thread Daniel Vetter
On Tue, Feb 28, 2017 at 06:13:15PM +0100, Daniel Vetter wrote: > From: Markus Heiser > > This patch brings scalable figure, image handling and a concept to > embed *render* markups: > > * DOT (http://www.graphviz.org) > * SVG > > For image handling use the 'image' replacement:: > > .. kern

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-03 Thread Markus Heiser
FYI >>> Yes, its only about "docutils>=0.11" in Sphinx 1.3 dependencies. >>> In Sphinx 1.5 the error: >>> >>> https://github.com/sphinx-doc/sphinx/issues/3212 >>> >>> is fixed: >>> >>> https://github.com/tk0miya/sphinx/commit/73663f63672f22304810ce6bb9787490ad250127 >>> >>> But this will ne

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Hi Daniel, hi Mauro, I have to say, that I lost control over our thread ;) > v3: Only sphinx 1.4 (released in Mar 2016) has patches.Figure. > Implement Markus suggestion for backwards compatability with earlier > releases. Laurent reported this, running sphinx 1.3. Solution entirely > untested.

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 23:15:49 +0100 Markus Heiser escreveu: > Hi Daniel, hi Mauro, > > I have to say, that I lost control over our thread ;) > > > v3: Only sphinx 1.4 (released in Mar 2016) has patches.Figure. > > Implement Markus suggestion for backwards compatability with earlier > > releases.

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 20:09 schrieb Mauro Carvalho Chehab > : ... >> >> Yes, its only about "docutils>=0.11" in Sphinx 1.3 dependencies. >> In Sphinx 1.5 the error: >> >> https://github.com/sphinx-doc/sphinx/issues/3212 >> >> is fixed: >> >> >> https://github.com/tk0miya/sphinx/commit/73663f

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 21:16:05 +0100 Markus Heiser escreveu: > > Am 02.03.2017 um 20:09 schrieb Mauro Carvalho Chehab > > : > I leaved a comment at sphinx-doc project: > > https://github.com/sphinx-doc/sphinx/issues/3212#issuecomment-283756374 Thanks! > > Maybe one way would be to have a so

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Daniel Vetter
On Thu, Mar 02, 2017 at 01:01:36PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 2 Mar 2017 16:53:04 +0100 > Daniel Vetter escreveu: > > > On Thu, Mar 2, 2017 at 4:22 PM, Jonathan Corbet wrote: > > > On Thu, 2 Mar 2017 16:11:08 +0100 > > > Daniel Vetter wrote: > > > > > >> I'll give it a shot

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 17:13:25 +0100 Markus Heiser escreveu: > > Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab > > : > > > >>> You can test it with virtualenv > >>> https://virtualenv.pypa.io/en/stable/userguide/ > >>> > >>> In short: > >>> > >>> $ cd kernel-src > >>> $ virtualenv mye

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 19:16:47 +0100 Markus Heiser escreveu: > > Am 02.03.2017 um 17:29 schrieb Mauro Carvalho Chehab > > : > > > > Em Thu, 2 Mar 2017 17:13:25 +0100 > > Markus Heiser escreveu: > > > >>> Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab > >>> : > >>> > > You can tes

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 19:20 schrieb Jonathan Corbet : > > On Thu, 2 Mar 2017 19:16:47 +0100 > Markus Heiser wrote: > >> This is very easy, if we use a requiremts.txt file where we >> stick the versions and run the sphinx in this build in a >> virtualenv which is build up by this requirements.txt.

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Jonathan Corbet
On Thu, 2 Mar 2017 19:16:47 +0100 Markus Heiser wrote: > This is very easy, if we use a requiremts.txt file where we > stick the versions and run the sphinx in this build in a > virtualenv which is build up by this requirements.txt. > > https://pip.pypa.io/en/stable/user_guide/#requirements-f

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 17:29 schrieb Mauro Carvalho Chehab > : > > Em Thu, 2 Mar 2017 17:13:25 +0100 > Markus Heiser escreveu: > >>> Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab >>> : >>> > You can test it with virtualenv > https://virtualenv.pypa.io/en/stable/userguide/ >

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab > : > >>> You can test it with virtualenv >>> https://virtualenv.pypa.io/en/stable/userguide/ >>> >>> In short: >>> >>> $ cd kernel-src >>> $ virtualenv myenv >>> $ source myenv/bin/activate >>> $ pip install 'Sphinx==1.3.1' >>> $ make .

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel and Markus, On Thursday 02 Mar 2017 16:11:08 Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: > > Am 02.03.2017 um 15:14 schrieb Laurent Pinchart: > > > On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: > > >> On Thu, Mar 2, 2017 at 1:26 PM, Laure

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Daniel Vetter
On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: > Hi Daniel, Laurent > > Am 02.03.2017 um 15:14 schrieb Laurent Pinchart > : > > > Hi Daniel, > > > > On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: > >> On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: > >>> Hi Daniel

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Daniel Vetter
On Thu, Mar 2, 2017 at 4:22 PM, Jonathan Corbet wrote: > On Thu, 2 Mar 2017 16:11:08 +0100 > Daniel Vetter wrote: > >> I'll give it a shot at implementing it, but I can't (easily at least) test >> on sphinx 1.3. > > Virtualenv makes that kind of thing pretty easy to do. Maybe we should > add a s

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 16:53:04 +0100 Daniel Vetter escreveu: > On Thu, Mar 2, 2017 at 4:22 PM, Jonathan Corbet wrote: > > On Thu, 2 Mar 2017 16:11:08 +0100 > > Daniel Vetter wrote: > > > >> I'll give it a shot at implementing it, but I can't (easily at least) test > >> on sphinx 1.3. > > > > V

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 12:45:32 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 2 Mar 2017 16:21:33 +0100 > Markus Heiser escreveu: > > > Am 02.03.2017 um 16:11 schrieb Daniel Vetter : > > > > > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: > > >> Hi Daniel, Laurent > > >>

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Jonathan Corbet
On Thu, 2 Mar 2017 16:11:08 +0100 Daniel Vetter wrote: > I'll give it a shot at implementing it, but I can't (easily at least) test > on sphinx 1.3. Virtualenv makes that kind of thing pretty easy to do. Maybe we should add a script to create and populate a suitable venv for this kind of thing.

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Am 02.03.2017 um 16:11 schrieb Daniel Vetter : > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: >> Hi Daniel, Laurent >> >> Am 02.03.2017 um 15:14 schrieb Laurent Pinchart >> : >> >>> Hi Daniel, >>> >>> On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: On Thu, Mar 2,

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Mauro Carvalho Chehab
Em Thu, 2 Mar 2017 16:21:33 +0100 Markus Heiser escreveu: > Am 02.03.2017 um 16:11 schrieb Daniel Vetter : > > > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: > >> Hi Daniel, Laurent > >> > >> Am 02.03.2017 um 15:14 schrieb Laurent Pinchart > >> : > >> > >>> Hi Daniel, >

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thursday 02 Mar 2017 16:16:34 Daniel Vetter wrote: > From: Markus Heiser > > This patch brings scalable figure, image handling and a concept to > embed *render* markups: > > * DOT (http://www.graphviz.org) > * SVG > > For image handling use the 'image' r

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Hi Daniel, Laurent Am 02.03.2017 um 15:14 schrieb Laurent Pinchart : > Hi Daniel, > > On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: >> On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: >>> Hi Daniel, >>> >>> Thank you for the patch. >>> >>> With this applied, I get >>> >>> make

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel, On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: > On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > With this applied, I get > > > > make[1]: Entering directory '/home/laurent/src/iob/renesas/linux64' > > > > SPHI

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Daniel Vetter
On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > With this applied, I get > > make[1]: Entering directory '/home/laurent/src/iob/renesas/linux64' > SPHINX htmldocs --> > file:///home/laurent/src/iob/renesas/linux64/Documentation/output > P

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. With this applied, I get make[1]: Entering directory '/home/laurent/src/iob/renesas/linux64' SPHINX htmldocs --> file:///home/laurent/src/iob/renesas/linux64/Documentation/output PARSE include/uapi/linux/videodev2.h Running Sphinx v1.3.1 Extension err

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Am 02.03.2017 um 08:12 schrieb Daniel Vetter : > On Wed, Mar 01, 2017 at 12:56:36PM -0300, Gabriel Krisman Bertazi wrote: >> Daniel Vetter writes: >> >> Hi Daniel, >> >>> +if dst_fname: >>> +name = dst_fname[len(out_dir) + 1:] >>> +# the builder needs not to copy one more t

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Daniel Vetter
On Wed, Mar 01, 2017 at 12:56:36PM -0300, Gabriel Krisman Bertazi wrote: > Daniel Vetter writes: > > Hi Daniel, > > > +if dst_fname: > > +name = dst_fname[len(out_dir) + 1:] > > +# the builder needs not to copy one more time, so pop it if exists. > > +translator.build

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-01 Thread Gabriel Krisman Bertazi
Daniel Vetter writes: Hi Daniel, > +if dst_fname: > +name = dst_fname[len(out_dir) + 1:] > +# the builder needs not to copy one more time, so pop it if exists. > +translator.builder.images.pop(img_node['uri'], None) > +img_node['uri'] = dst_fname > +im