Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Borislav Petkov
On Fri, Oct 28, 2016 at 01:43:08PM -0200, Mauro Carvalho Chehab wrote: > The prototypes and function definitions at edac_core.h will need to > be moved anyway at the split. Having everything together and then > breaking it seem an easier way to warrant that everything will be > moved to their right

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Oct 2016 17:00:34 +0200 Borislav Petkov escreveu: > On Fri, Oct 28, 2016 at 12:50:06PM -0200, Mauro Carvalho Chehab wrote: > > I'll add a patch at the end of this series with such break, remove patch 3 > > and repost (either later today or after the KS/LPC week). > > Or you could si

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Borislav Petkov
On Fri, Oct 28, 2016 at 12:50:06PM -0200, Mauro Carvalho Chehab wrote: > I'll add a patch at the end of this series with such break, remove patch 3 > and repost (either later today or after the KS/LPC week). Or you could simply move the kernel-doc comments to the respective header files directly i

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Oct 2016 16:40:06 +0200 Borislav Petkov escreveu: > On Fri, Oct 28, 2016 at 12:29:08PM -0200, Mauro Carvalho Chehab wrote: > > drivers/edac/edac_device.h > > drivers/edac/edac_device_sysfs.h > > drivers/edac/edac_mc.h > > drivers/edac/edac_mc_sysfs.h > > drivers/eda

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Borislav Petkov
On Fri, Oct 28, 2016 at 12:29:08PM -0200, Mauro Carvalho Chehab wrote: > drivers/edac/edac_device.h > drivers/edac/edac_device_sysfs.h > drivers/edac/edac_mc.h > drivers/edac/edac_mc_sysfs.h > drivers/edac/edac_pci.h > drivers/edac/edac_pci_sysfs.h > driver

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Oct 2016 16:20:24 +0200 Borislav Petkov escreveu: > On Wed, Oct 26, 2016 at 05:58:54PM -0200, Mauro Carvalho Chehab wrote: > > Several functions are documented at edac_mc.c. > > > > As we'll be including edac_core.h at drivers-api book, move > > those, in order for the kernel-doc mark

Re: [PATCH 04/12] edac: move documentation from edac_mc.c to edac_core.h

2016-10-28 Thread Borislav Petkov
On Wed, Oct 26, 2016 at 05:58:54PM -0200, Mauro Carvalho Chehab wrote: > Several functions are documented at edac_mc.c. > > As we'll be including edac_core.h at drivers-api book, move > those, in order for the kernel-doc markups be part of the API > documentation book. So what is the story now?