Re: [PATCH] pci-error-recover: doc cleanup

2016-12-18 Thread Cao jin
Sorry for late. On 12/09/2016 10:37 PM, Jonathan Corbet wrote: > On Fri, 9 Dec 2016 14:37:47 +0800 > Cao jin wrote: > >> I am little confused too, even not sure if we are talking the same >> *fatal error*, I am talking the fatal error defined in PCI Express spec, >> chapter 6.2.2.2.1: > > There

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-13 Thread Gavin Shan
On Fri, Dec 09, 2016 at 05:50:17PM +1100, Andrew Donnellan wrote: >On 09/12/16 17:24, Linas Vepstas wrote: >>I suppose I'm confused, but I recall that link resets are non-fatal. >>Fatal errors typically require that the the pci adapter be completely >>reset, any adapter firmware to be reloaded from

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-09 Thread Alex Williamson
On Fri, 9 Dec 2016 14:44:25 +0800 Linas Vepstas wrote: > On Fri, Dec 9, 2016 at 2:37 PM, Cao jin wrote: > > > > > > On 12/09/2016 02:24 PM, Linas Vepstas wrote: > >> I suppose I'm confused, but I recall that link resets are non-fatal. > >> Fatal errors typically require that the the pci adapte

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-09 Thread Jonathan Corbet
On Fri, 9 Dec 2016 14:37:47 +0800 Cao jin wrote: > I am little confused too, even not sure if we are talking the same > *fatal error*, I am talking the fatal error defined in PCI Express spec, > chapter 6.2.2.2.1: Therein lies my original discomfort with the change; it didn't seem to make sense

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Cao jin
On 12/09/2016 02:44 PM, Linas Vepstas wrote: > On Fri, Dec 9, 2016 at 2:37 PM, Cao jin wrote: >> >> >> On 12/09/2016 02:24 PM, Linas Vepstas wrote: >>> I suppose I'm confused, but I recall that link resets are non-fatal. >>> Fatal errors typically require that the the pci adapter be completely >

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Cao jin
On 12/09/2016 02:24 PM, Linas Vepstas wrote: > I suppose I'm confused, but I recall that link resets are non-fatal. > Fatal errors typically require that the the pci adapter be completely > reset, any adapter firmware to be reloaded from scratch, the device > driver has to kill all device state a

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Andrew Donnellan
On 09/12/16 17:24, Linas Vepstas wrote: I suppose I'm confused, but I recall that link resets are non-fatal. Fatal errors typically require that the the pci adapter be completely reset, any adapter firmware to be reloaded from scratch, the device driver has to kill all device state and start from

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Linas Vepstas
On Fri, Dec 9, 2016 at 2:37 PM, Cao jin wrote: > > > On 12/09/2016 02:24 PM, Linas Vepstas wrote: >> I suppose I'm confused, but I recall that link resets are non-fatal. >> Fatal errors typically require that the the pci adapter be completely >> reset, any adapter firmware to be reloaded from scra

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Linas Vepstas
I suppose I'm confused, but I recall that link resets are non-fatal. Fatal errors typically require that the the pci adapter be completely reset, any adapter firmware to be reloaded from scratch, the device driver has to kill all device state and start from scratch. Its huge. If the fatal error is

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Cao jin
On 12/08/2016 10:05 PM, Jonathan Corbet wrote: > On Thu, 8 Dec 2016 16:16:14 +0800 > Cao jin wrote: > >> The platform resets the link, and then calls the link_reset() callback >> on all affected device drivers. This is a PCI-Express specific state >> -and is done whenever a non-fatal error h

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Jonathan Corbet
On Thu, 8 Dec 2016 16:16:14 +0800 Cao jin wrote: > The platform resets the link, and then calls the link_reset() callback > on all affected device drivers. This is a PCI-Express specific state > -and is done whenever a non-fatal error has been detected that can be > +and is done whenever a fat