Re: [PATCH] mm, oom: simplify alloc_pages_before_oomkill handling

2017-12-01 Thread Michal Hocko
On Fri 01-12-17 13:32:15, Roman Gushchin wrote: > Hi, Michal! > > I totally agree that out_of_memory() function deserves some refactoring. > > But I think there is an issue with your patch (see below): > > On Fri, Dec 01, 2017 at 10:14:25AM +0100, Michal Hocko wrote: > > Recently added alloc_pag

Re: [PATCH] mm, oom: simplify alloc_pages_before_oomkill handling

2017-12-01 Thread Roman Gushchin
Hi, Michal! I totally agree that out_of_memory() function deserves some refactoring. But I think there is an issue with your patch (see below): On Fri, Dec 01, 2017 at 10:14:25AM +0100, Michal Hocko wrote: > Recently added alloc_pages_before_oomkill gained new caller with this > patchset and I t

Re: [PATCH] mm, oom: simplify alloc_pages_before_oomkill handling

2017-12-01 Thread Tetsuo Handa
Michal Hocko wrote: > Recently added alloc_pages_before_oomkill gained new caller with this > patchset and I think it just grown to deserve a simpler code flow. > What do you think about this on top of the series? I'm planning to post below patch in order to mitigate OOM lockup problem caused by s