RE: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-02 Thread Sell, Timothy C
@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; *S-Par-Maintainer > Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove > unnecessary locking > > On Tue, 31 May 2016, David Kershner wrote: > > + /* > > +* If we're not paused, really enable inter

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-02 Thread Neil Horman
nder, David Anthony; dan.j.willi...@intel.com; > > linux-ker...@vger.kernel.org; linux-doc@vger.kernel.org; driverdev- > > de...@linuxdriverproject.org; *S-Par-Maintainer > > Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove > > unnecessary locking > >

RE: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Sell, Timothy C
@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; *S-Par-Maintainer > Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove > unnecessary locking > > On Wed, Jun 01, 2016 at 03:09:13PM +, Sell, Timothy C wrote: > > > -Original Message- > > > From: Neil

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
David Anthony; > > dan.j.willi...@intel.com; linux-ker...@vger.kernel.org; linux- > > d...@vger.kernel.org; driverdev-de...@linuxdriverproject.org; *S-Par- > > Maintainer > > Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove > > unnecessary locking >

RE: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Sell, Timothy C
...@vger.kernel.org; driverdev-de...@linuxdriverproject.org; *S-Par- > Maintainer > Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove > unnecessary locking > > On Tue, May 31, 2016 at 10:26:36PM -0400, David Kershner wrote: > > From: Tim Sell > > > > Locking in the _i

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:36PM -0400, David Kershner wrote: > From: Tim Sell > > Locking in the _interrupt() function is NOT necessary so long as we ensure > that interrupts have been stopped whenever we need to pause or resume the > device, which we now do. > > While a device is paused, we

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-05-31 Thread Thomas Gleixner
On Tue, 31 May 2016, David Kershner wrote: > + /* > + * If we're not paused, really enable interrupts. > + * Regardless of whether we are paused, set a flag indicating > + * interrupts should be enabled so when we resume, interrupts > + * will really be enabled. > + */