Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 1:49 AM Christoph Hellwig wrote: > > On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > > } while (start = next, start < end); > > return err; > > } > > +EXPORT_SYMBOL_GPL(walk_page_range); > > Umm, no. We really should not expose all these page

Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-18 Thread Lorenzo Stoakes
On Sun, Nov 17, 2024 at 10:49:06PM -0800, Christoph Hellwig wrote: > On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > > } while (start = next, start < end); > > return err; > > } > > +EXPORT_SYMBOL_GPL(walk_page_range); > > Umm, no. We really should not expose all these p

Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-17 Thread Christoph Hellwig
On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > } while (start = next, start < end); > return err; > } > +EXPORT_SYMBOL_GPL(walk_page_range); Umm, no. We really should not expose all these page table detail to modules. > +EXPORT_SYMBOL_GPL(walk_page_range_kernel);

[RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-16 Thread Pasha Tatashin
Page Detective will use it to walk the kernel page table. Make this function accessible from modules, and also while here make walk_page_range() accessible from modules, so Page Detective could use it to walk user page tables. Signed-off-by: Pasha Tatashin --- include/linux/pagewalk.h | 2 ++ m