Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 3:44 PM Matthew Wilcox wrote: > > On Mon, Nov 18, 2024 at 03:40:57PM -0500, Pasha Tatashin wrote: > > > You're putting something in an mm/ C-file and the header in fs.h? Eh? > > > > This is done so we do not have to include struct path into vma.h. fs.h > > already has some

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Matthew Wilcox
On Mon, Nov 18, 2024 at 03:40:57PM -0500, Pasha Tatashin wrote: > > You're putting something in an mm/ C-file and the header in fs.h? Eh? > > This is done so we do not have to include struct path into vma.h. fs.h > already has some vma functions like: vma_is_dax() and vma_is_fsdax(). Yes, but DAX

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 5:27 AM Lorenzo Stoakes wrote: > > On Sat, Nov 16, 2024 at 05:59:17PM +, Pasha Tatashin wrote: > > Page Detective will be using get_vma_name() that is currently used by > > fs/proc to show names of VMAs in /proc//smaps for example. > > > > Move this function to mm/vma.c

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Lorenzo Stoakes
On Sat, Nov 16, 2024 at 05:59:17PM +, Pasha Tatashin wrote: > Page Detective will be using get_vma_name() that is currently used by > fs/proc to show names of VMAs in /proc//smaps for example. > > Move this function to mm/vma.c, and make it accessible by modules. This is incorrect. mm/vma.c i

[RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-16 Thread Pasha Tatashin
Page Detective will be using get_vma_name() that is currently used by fs/proc to show names of VMAs in /proc//smaps for example. Move this function to mm/vma.c, and make it accessible by modules. Signed-off-by: Pasha Tatashin --- fs/proc/task_mmu.c | 61 -