Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-19 Thread Tejun Heo
Hello, On Fri, May 19, 2017 at 03:33:14PM -0400, Waiman Long wrote: > On 05/19/2017 03:21 PM, Tejun Heo wrote: > > Yeah but it also shows up as an integral part of stable interface > > rather than e.g. /sys/kernel/debug. This isn't of any interest to > > people who aren't developing cgroup core c

Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-19 Thread Waiman Long
On 05/19/2017 03:21 PM, Tejun Heo wrote: > Hello, Waiman. > > On Thu, May 18, 2017 at 11:52:18AM -0400, Waiman Long wrote: >> The controller name is "debug" and so it is obvious what this controller >> is for. However, the config prompt "Example controller" is indeed vague > Yeah but it also shows

Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-19 Thread Tejun Heo
Hello, Waiman. On Thu, May 18, 2017 at 11:52:18AM -0400, Waiman Long wrote: > The controller name is "debug" and so it is obvious what this controller > is for. However, the config prompt "Example controller" is indeed vague Yeah but it also shows up as an integral part of stable interface rather

Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-18 Thread Waiman Long
On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into it

Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-18 Thread Waiman Long
On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into it

Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-17 Thread Tejun Heo
Hello, Waiman. On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: > The debug cgroup currently resides within cgroup-v1.c and is enabled > only for v1 cgroup. To enable the debug cgroup also for v2, it > makes sense to put the code into its own file as it will no longer > be v1 specific.

[RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

2017-05-15 Thread Waiman Long
The debug cgroup currently resides within cgroup-v1.c and is enabled only for v1 cgroup. To enable the debug cgroup also for v2, it makes sense to put the code into its own file as it will no longer be v1 specific. The only change in this patch is the expansion of cgroup_task_count() within the deb