Re: [RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-14 Thread Jani Nikula
On Thu, 10 May 2018, Jonathan Corbet wrote: > On Thu, 10 May 2018 09:34:56 -0700 > Matthew Wilcox wrote: > >> I think this is a bit fragile. Why not just search for ':\n'? Is >> there ever a case where we want to write: >> >> /** >> * foo is a bar: >> * wibble >> */ >> and have wibble not b

Re: [RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 09:34:56 -0700 Matthew Wilcox wrote: > I think this is a bit fragile. Why not just search for ':\n'? Is > there ever a case where we want to write: > > /** > * foo is a bar: > * wibble > */ > and have wibble not be a code-block? Yeah, we might want to write something li

Re: [RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Matthew Wilcox
On Thu, May 10, 2018 at 10:38:16AM -0400, Mauro Carvalho Chehab wrote: > Comments that end with a comma and have certain keywords > should be presented as code-blocks I think this is a bit fragile. Why not just search for ':\n'? Is there ever a case where we want to write: /** * foo is a bar:

[RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Mauro Carvalho Chehab
Comments that end with a comma and have certain keywords should be presented as code-blocks Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 0057d8eafcc1..8ce2d0f54369 1