Hi Tejun,
On Thu, Mar 17, 2016 at 2:10 AM, Tejun Heo wrote:
>
>> If this is ok. I will keep the code as it is, because it uses common
>> helper functions for max and current files.
>
> Hmmm... can you please try to refactor the common part to helpers?
> It's not a big thing but there were both st
Hello, Parav.
Sorry about the delay.
On Sat, Mar 12, 2016 at 11:49:03AM +0530, Parav Pandit wrote:
> > For (1) shall I have one spin lock that is uses across multiple
> > hierarchy and multiple cgroup.
> > Essentially one global lock among all cgroup. During hierarchical
> > charging, continue to
Hi Tejun,
On Sat, Mar 5, 2016 at 10:50 PM, Parav Pandit wrote:
> Hi Tejun,
>
> On Sat, Mar 5, 2016 at 6:22 PM, Tejun Heo wrote:
>> Hello, Parav.
>>
>> On Sat, Mar 05, 2016 at 04:45:09PM +0530, Parav Pandit wrote:
>>> Design that remains same from v6 to v10.
>>> * spin lock is still fine graine
On 05/03/2016 19:20, Parav Pandit wrote:
>> > 3 is fine but resource [un]charging is not hot path?
> charge/uncharge is hot path from cgroup perspective.
Most of the resources the RDMA cgroup handles are only allocated at
the beginning of the application. The RDMA subsystem allows direct
user-spac
Hi Tejun,
On Sat, Mar 5, 2016 at 6:22 PM, Tejun Heo wrote:
> Hello, Parav.
>
> On Sat, Mar 05, 2016 at 04:45:09PM +0530, Parav Pandit wrote:
>> Design that remains same from v6 to v10.
>> * spin lock is still fine grained at cgroup level instead of one
>> global shared lock among all cgroups.
>
Hello, Parav.
On Sat, Mar 05, 2016 at 04:45:09PM +0530, Parav Pandit wrote:
> Design that remains same from v6 to v10.
> * spin lock is still fine grained at cgroup level instead of one
> global shared lock among all cgroups.
> In future it can be optimized further to do per cpu or using
>
Hi Tejun,
I would like to submit patch v10.
Can you please confirm that you are ok (or not) with the current
design and below changes should be good enough?
I am ok if you directly want to jump to review v10 too.
Changes from v9:
* Included documentation of resources in v2.txt and v1.txt
* Fi
On Thu, Mar 3, 2016 at 1:44 PM, Haggai Eran wrote:
> On 03/03/2016 05:18, Parav Pandit wrote:
>> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit wrote:
>>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo wrote:
Nothing seems to prevent @cg from going away if this races with
@current being migr
On 03/03/2016 05:18, Parav Pandit wrote:
> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit wrote:
>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo wrote:
>>> Nothing seems to prevent @cg from going away if this races with
>>> @current being migrated to a different cgroup. Have you run this with
>>> lo
On 03/03/2016 04:49, Parav Pandit wrote:
> Hi Tejun, Haggai,
>
> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit wrote:
+ rpool->refcnt--;
+ if (rpool->refcnt == 0 && rpool->num_max_cnt ==
pool_info->table_len) {
>>>
>>> If the caller charges 2 and then uncharges 1 two times,
On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit wrote:
> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo wrote:
>> Nothing seems to prevent @cg from going away if this races with
>> @current being migrated to a different cgroup. Have you run this with
>> lockdep and rcu debugging enabled? This should h
Hi Tejun, Haggai,
On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit wrote:
>>> + rpool->refcnt--;
>>> + if (rpool->refcnt == 0 && rpool->num_max_cnt == pool_info->table_len)
>>> {
>>
>> If the caller charges 2 and then uncharges 1 two times, the refcnt
>> underflows? Why not just track how m
On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo wrote:
> Hello,
>
>> +struct rdma_cgroup {
>> + struct cgroup_subsys_state css;
>> +
>> + spinlock_t rpool_list_lock; /* protects resource pool list */
>> + struct list_head rpool_head;/* head to keep track of all resource
>> +
Hello,
On Wed, Mar 02, 2016 at 12:35:35AM +0530, Parav Pandit wrote:
> diff --git a/include/linux/cgroup_rdma.h b/include/linux/cgroup_rdma.h
> new file mode 100644
> index 000..2da3d6c
> --- /dev/null
> +++ b/include/linux/cgroup_rdma.h
> @@ -0,0 +1,50 @@
> +#ifndef _CGROUP_RDMA_H
> +#define
Added rdma cgroup controller that does accounting, limit enforcement
on rdma/IB verbs and hw resources.
Added rdma cgroup header file which defines its APIs to perform
charing/uncharing functionality and device registration which will
participate in controller functions of accounting and limit
enf
15 matches
Mail list logo