Re: [PATCHv3] hwmon: Add tc654 driver

2016-10-10 Thread Guenter Roeck
On Mon, Oct 10, 2016 at 08:08:14PM +, Chris Packham wrote: > On 10/11/2016 02:22 AM, Guenter Roeck wrote: > >> + if (val) > >> > +data->config |= TC654_REG_CONFIG_DUTYC; > >> > +else > >> > +data->config &= ~TC654_REG_CONFIG_DUTYC; > > I just realized th

Re: [PATCHv3] hwmon: Add tc654 driver

2016-10-10 Thread Chris Packham
On 10/11/2016 02:22 AM, Guenter Roeck wrote: >> +if (val) >> > + data->config |= TC654_REG_CONFIG_DUTYC; >> > + else >> > + data->config &= ~TC654_REG_CONFIG_DUTYC; > I just realized that this won't work as intended. Problem is that you > only fill data->config when reading a

Re: [PATCHv3] hwmon: Add tc654 driver

2016-10-10 Thread Guenter Roeck
On 10/09/2016 03:12 PM, Chris Packham wrote: Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham --- Changes in v3: - typofix in documentation - add missing value to tc654_pwm_map, re-gen

[PATCHv3] hwmon: Add tc654 driver

2016-10-09 Thread Chris Packham
Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham --- Changes in v3: - typofix in documentation - add missing value to tc654_pwm_map, re-generate based on datasheet. - remove unnecessary