Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-25 Thread Juri Lelli
On 25/05/18 11:31, Patrick Bellasi wrote: [...] > Right, so the problem seems to be that we "need" to call > arch_update_cpu_topology() and we do that by calling > partition_sched_domains() which was initially introduced by: > >029190c515f1 ("cpuset sched_load_balance flag") > > back in 200

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-25 Thread Patrick Bellasi
Hi Juri, following are some notes I took while trying to understand what's going on... could be useful to understand if I have a correct view of all the different components and how they come together. At the end there are also a couple of possible updates and a question on your proposal. Cheers

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-24 Thread Juri Lelli
On 24/05/18 10:04, Patrick Bellasi wrote: [...] > From 84bb8137ce79f74849d97e30871cf67d06d8d682 Mon Sep 17 00:00:00 2001 > From: Patrick Bellasi > Date: Wed, 23 May 2018 16:33:06 +0100 > Subject: [PATCH 1/1] cgroup/cpuset: disable sched domain rebuild when not > required > > The generate_sched

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-24 Thread Juri Lelli
On 17/05/18 16:55, Waiman Long wrote: [...] > @@ -849,7 +860,12 @@ static void rebuild_sched_domains_locked(void) >* passing doms with offlined cpu to partition_sched_domains(). >* Anyways, hotplug work item will rebuild sched domains. >*/ > - if (!cpumask_equal(top_cp

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-24 Thread Patrick Bellasi
On 23-May 16:18, Waiman Long wrote: > On 05/23/2018 01:34 PM, Patrick Bellasi wrote: > > Hi Waiman, > > > > On 17-May 16:55, Waiman Long wrote: > > > > [...] > > > >> @@ -672,13 +672,14 @@ static int generate_sched_domains(cpumask_var_t > >> **domains, > >>int ndoms = 0; /* number of

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-23 Thread Waiman Long
On 05/23/2018 01:34 PM, Patrick Bellasi wrote: > Hi Waiman, > > On 17-May 16:55, Waiman Long wrote: > > [...] > >> @@ -672,13 +672,14 @@ static int generate_sched_domains(cpumask_var_t >> **domains, >> int ndoms = 0; /* number of sched domains in result */ >> int nslot;

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-23 Thread Patrick Bellasi
Hi Waiman, On 17-May 16:55, Waiman Long wrote: [...] > @@ -672,13 +672,14 @@ static int generate_sched_domains(cpumask_var_t > **domains, > int ndoms = 0; /* number of sched domains in result */ > int nslot; /* next empty doms[] struct cpumask slot */ > s

[PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-17 Thread Waiman Long
The generate_sched_domains() function and the hotplug code are modified to make them use the newly introduced isolated_cpus mask for schedule domains generation. Signed-off-by: Waiman Long --- kernel/cgroup/cpuset.c | 33 + 1 file changed, 29 insertions(+), 4 dele