Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Mathieu Poirier
On 6 April 2017 at 07:30, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based Profiling Extens

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Mathieu Poirier
On 19 April 2017 at 09:30, Leo Yan wrote: > On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: > > [...] > >> >> > +static bool debug_enable; >> >> > +module_param_named(enable, debug_enable, bool, 0600); >> >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " >> >> >

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: [...] > >> > +static bool debug_enable; > >> > +module_param_named(enable, debug_enable, bool, 0600); > >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " > >> > +"(default is 0, which means is disabled

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
On Wed, Apr 19, 2017 at 03:32:39PM +0100, Suzuki K Poulose wrote: [...] > >>>+static int debug_probe(struct amba_device *adev, const struct amba_id *id) > >>>+{ > >>>+ void __iomem *base; > >>>+ struct device *dev = &adev->dev; > >>>+ struct debug_drvdata *drvdata; > >>>+ struct resource *res

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Mathieu Poirier
On 18 April 2017 at 18:18, Leo Yan wrote: > On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: >> On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: >> > Coresight includes debug module and usually the module connects with CPU >> > debug logic. ARMv8 architecture reference manu

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Suzuki K Poulose
On 19/04/17 15:28, Leo Yan wrote: Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: Hi Leo, This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] +static int debu

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] > >+static int debug_probe(struct amba_device *ad

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Suzuki K Poulose
On 06/04/17 14:30, Leo Yan wrote: Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension" introduces

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-18 Thread Leo Yan
On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: > On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > > Coresight includes debug module and usually the module connects with CPU > > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > > description for rel

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-18 Thread Mathieu Poirier
On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based

[PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-06 Thread Leo Yan
Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension" introduces several sampling registers, e.g. we