Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-25 Thread Roberto Sassu
On Mon, 2024-11-25 at 15:40 -0800, Luis Chamberlain wrote: > On Wed, Nov 20, 2024 at 10:16:23AM +0100, Roberto Sassu wrote: > > Again, maybe I misunderstood, but I'm not introducing any functional > > change to the current behavior, the kernel side also provides a file > > descriptor and module arg

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-25 Thread Luis Chamberlain
On Wed, Nov 20, 2024 at 10:16:23AM +0100, Roberto Sassu wrote: > Again, maybe I misunderstood, but I'm not introducing any functional > change to the current behavior, the kernel side also provides a file > descriptor and module arguments as user space would do (e.g. by > executing insmod). The co

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-20 Thread Roberto Sassu
On Wed, 2024-11-20 at 10:16 +0100, Roberto Sassu wrote: > On Tue, 2024-11-19 at 12:10 -0800, Luis Chamberlain wrote: > > On Tue, Nov 19, 2024 at 01:14:02PM +0100, Christoph Hellwig wrote: > > > On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > > > > From: Roberto Sassu > > > > > >

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-20 Thread Roberto Sassu
On Tue, 2024-11-19 at 12:10 -0800, Luis Chamberlain wrote: > On Tue, Nov 19, 2024 at 01:14:02PM +0100, Christoph Hellwig wrote: > > On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > > > From: Roberto Sassu > > > > > > Introduce ksys_finit_module() to let kernel components request a

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-19 Thread Luis Chamberlain
On Tue, Nov 19, 2024 at 01:14:02PM +0100, Christoph Hellwig wrote: > On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Introduce ksys_finit_module() to let kernel components request a kernel > > module without requiring running modprobe. > > That does

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-19 Thread Roberto Sassu
On Tue, 2024-11-19 at 13:14 +0100, Christoph Hellwig wrote: > On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Introduce ksys_finit_module() to let kernel components request a kernel > > module without requiring running modprobe. > > That does sound

Re: [PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-19 Thread Christoph Hellwig
On Tue, Nov 19, 2024 at 11:49:09AM +0100, Roberto Sassu wrote: > From: Roberto Sassu > > Introduce ksys_finit_module() to let kernel components request a kernel > module without requiring running modprobe. That does sound more than sketchy, even more so because the commit log completely fails to

[PATCH v6 02/15] module: Introduce ksys_finit_module()

2024-11-19 Thread Roberto Sassu
From: Roberto Sassu Introduce ksys_finit_module() to let kernel components request a kernel module without requiring running modprobe. Signed-off-by: Roberto Sassu --- include/linux/syscalls.h | 10 ++ kernel/module/main.c | 43 ++-- 2 files chan