Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 15:55:28+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: [..] > > > +typedef int (*callback)(void *callback_data, __u16 field, > > > + const __u8 *field_data, __u32 field_le

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > Hi Robert, > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > +--+--+-++-+ > > > field1 (u16) | l

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 15:21 +0100, Thomas Weißschuh wrote: > On 2025-01-21 14:48:09+0100, Roberto Sassu wrote: > > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > > Hi Robert, > > > > > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > > > From: Roberto Sassu > > > > > > > >

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 14:48:09+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > Hi Robert, > > > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > > From: Roberto Sassu > > > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > > > +--

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > Hi Robert, > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > +--+--+-++-+ > > > field1 (u16) | l

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
Hi Robert, On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > From: Roberto Sassu > > Add a parser of a generic Type-Length-Value (TLV) format: > > +--+--+-++-+ > | field1 (u16) | len1 (u32) | value1 (u8 len1) | > +--++---

Re: [PATCH v6 01/15] lib: Add TLV parser

2024-11-19 Thread Randy Dunlap
Hi-- On 11/19/24 2:49 AM, Roberto Sassu wrote: > +/** > + * typedef callback - Callback after parsing TLV entry Same as my other naming comment -- too generic. Maybe tlv_callback... Thanks. > + * @callback_data: Opaque data to supply to the callback function > + * @field: Field identifier > + *

[PATCH v6 01/15] lib: Add TLV parser

2024-11-19 Thread Roberto Sassu
From: Roberto Sassu Add a parser of a generic Type-Length-Value (TLV) format: +--+--+-++-+ | field1 (u16) | len1 (u32) | value1 (u8 len1) | +--++--+ | ... |... |... | +--+--