Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-19 Thread Joao Martins
On 11/19/21 19:53, Jason Gunthorpe wrote: > On Fri, Nov 19, 2021 at 07:26:44PM +, Joao Martins wrote: >> On 11/19/21 16:55, Jason Gunthorpe wrote: >>> On Fri, Nov 19, 2021 at 04:12:18PM +, Joao Martins wrote: >>> > Dan, any thoughts (see also below) ? You probably hold all that > hi

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-19 Thread Jason Gunthorpe
On Fri, Nov 19, 2021 at 07:26:44PM +, Joao Martins wrote: > On 11/19/21 16:55, Jason Gunthorpe wrote: > > On Fri, Nov 19, 2021 at 04:12:18PM +, Joao Martins wrote: > > > >>> Dan, any thoughts (see also below) ? You probably hold all that > >>> history since its inception on commit 2232c638

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-19 Thread Joao Martins
On 11/19/21 16:55, Jason Gunthorpe wrote: > On Fri, Nov 19, 2021 at 04:12:18PM +, Joao Martins wrote: > >>> Dan, any thoughts (see also below) ? You probably hold all that >>> history since its inception on commit 2232c6382a4 ("device-dax: Enable >>> page_mapping()") >>> and commit 35de299547

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-19 Thread Jason Gunthorpe
On Fri, Nov 19, 2021 at 04:12:18PM +, Joao Martins wrote: > > Dan, any thoughts (see also below) ? You probably hold all that > > history since its inception on commit 2232c6382a4 ("device-dax: Enable > > page_mapping()") > > and commit 35de299547d1 ("device-dax: Set page->index"). > > > Bel

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-19 Thread Joao Martins
On 11/16/21 16:38, Joao Martins wrote: > On 11/15/21 17:49, Jason Gunthorpe wrote: >> On Mon, Nov 15, 2021 at 01:11:32PM +0100, Joao Martins wrote: >>> On 11/12/21 16:34, Jason Gunthorpe wrote: On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > diff --git a/drivers/dax/device.

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-17 Thread Joao Martins
On 11/17/21 10:43, Christoph Hellwig wrote: > On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: >> Use the newly added compound devmap facility which maps the assigned dax >> ranges as compound pages at a page size of @align. >> >> dax devices are created with a fixed @align (huge page

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-17 Thread Christoph Hellwig
On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > Use the newly added compound devmap facility which maps the assigned dax > ranges as compound pages at a page size of @align. > > dax devices are created with a fixed @align (huge page size) which is > enforced through as well at mmap

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-16 Thread Joao Martins
On 11/15/21 17:49, Jason Gunthorpe wrote: > On Mon, Nov 15, 2021 at 01:11:32PM +0100, Joao Martins wrote: >> On 11/12/21 16:34, Jason Gunthorpe wrote: >>> On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: diff --git a/drivers/dax/device.c b/drivers/dax/device.c index a65c67ab5

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-15 Thread Jason Gunthorpe
On Mon, Nov 15, 2021 at 01:11:32PM +0100, Joao Martins wrote: > On 11/12/21 16:34, Jason Gunthorpe wrote: > > On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > > > >> diff --git a/drivers/dax/device.c b/drivers/dax/device.c > >> index a65c67ab5ee0..0c2ac97d397d 100644 > >> +++ b/driv

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-15 Thread Joao Martins
On 11/12/21 16:34, Jason Gunthorpe wrote: > On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > >> diff --git a/drivers/dax/device.c b/drivers/dax/device.c >> index a65c67ab5ee0..0c2ac97d397d 100644 >> +++ b/drivers/dax/device.c >> @@ -192,6 +192,42 @@ static vm_fault_t __dev_dax_pud_f

Re: [PATCH v5 8/8] device-dax: compound devmap support

2021-11-12 Thread Jason Gunthorpe
On Fri, Nov 12, 2021 at 04:08:24PM +0100, Joao Martins wrote: > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index a65c67ab5ee0..0c2ac97d397d 100644 > +++ b/drivers/dax/device.c > @@ -192,6 +192,42 @@ static vm_fault_t __dev_dax_pud_fault(struct dev_dax > *dev_dax, > } > #endif /*

[PATCH v5 8/8] device-dax: compound devmap support

2021-11-12 Thread Joao Martins
Use the newly added compound devmap facility which maps the assigned dax ranges as compound pages at a page size of @align. dax devices are created with a fixed @align (huge page size) which is enforced through as well at mmap() of the device. Faults, consequently happen too at the specified @alig