Re: [PATCH v5 7/8] device-dax: ensure dev_dax->pgmap is valid for dynamic devices

2021-11-17 Thread Joao Martins
On 11/17/21 10:37, Christoph Hellwig wrote: >> +bool static_dev_dax(struct dev_dax *dev_dax) >> +{ >> +return is_static(dev_dax->region); >> +} >> +EXPORT_SYMBOL_GPL(static_dev_dax); > > This function would massively benefit from documentic what a static > DAX region is and why someone woul

Re: [PATCH v5 7/8] device-dax: ensure dev_dax->pgmap is valid for dynamic devices

2021-11-17 Thread Christoph Hellwig
> +bool static_dev_dax(struct dev_dax *dev_dax) > +{ > + return is_static(dev_dax->region); > +} > +EXPORT_SYMBOL_GPL(static_dev_dax); This function would massively benefit from documentic what a static DAX region is and why someone would want to care. Because even as someone occasionally dab

[PATCH v5 7/8] device-dax: ensure dev_dax->pgmap is valid for dynamic devices

2021-11-12 Thread Joao Martins
Right now, only static dax regions have a valid @pgmap pointer in its struct dev_dax. Dynamic dax case however, do not. In preparation for device-dax compound devmap support, make sure that dev_dax pgmap field is set after it has been allocated and initialized. dynamic dax device have the @pgmap