Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-20 Thread Roman Gushchin
On Thu, Dec 20, 2018 at 05:16:50PM +0100, Oleg Nesterov wrote: > On 12/18, Roman Gushchin wrote: > > > > > > > > --- a/kernel/freezer.c > > > > > > +++ b/kernel/freezer.c > > > > > > @@ -134,7 +134,7 @@ bool freeze_task(struct task_struct *p) > > > > > > return false; > > > > > > >

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-20 Thread Oleg Nesterov
On 12/18, Roman Gushchin wrote: > > > > > > --- a/kernel/freezer.c > > > > > +++ b/kernel/freezer.c > > > > > @@ -134,7 +134,7 @@ bool freeze_task(struct task_struct *p) > > > > > return false; > > > > > > > > > > spin_lock_irqsave(&freezer_lock, flags); > > > > > - if

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-18 Thread Roman Gushchin
On Tue, Dec 18, 2018 at 06:12:30PM +0100, Oleg Nesterov wrote: > On 12/18, Roman Gushchin wrote: > > > > On Wed, Dec 12, 2018 at 06:49:02PM +0100, Oleg Nesterov wrote: > > > > > and btw what about suspend? try_to_freeze_tasks() will obviously > > > > > fail > > > > > if there is a ->frozen thr

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-18 Thread Oleg Nesterov
On 12/18, Roman Gushchin wrote: > > On Wed, Dec 12, 2018 at 06:49:02PM +0100, Oleg Nesterov wrote: > > > > and btw what about suspend? try_to_freeze_tasks() will obviously > > > > fail > > > > if there is a ->frozen thread? > > > > > > I have to think a bit more here, but something like this w

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-17 Thread Roman Gushchin
On Wed, Dec 12, 2018 at 06:49:02PM +0100, Oleg Nesterov wrote: > On 12/11, Roman Gushchin wrote: > > > > On Tue, Dec 11, 2018 at 05:26:32PM +0100, Oleg Nesterov wrote: > > > On 12/07, Roman Gushchin wrote: > > > > > > > > Cgroup v2 freezer tries to put tasks into a state similar to jobctl > > > > s

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-12 Thread Oleg Nesterov
On 12/11, Roman Gushchin wrote: > > On Tue, Dec 11, 2018 at 05:26:32PM +0100, Oleg Nesterov wrote: > > On 12/07, Roman Gushchin wrote: > > > > > > Cgroup v2 freezer tries to put tasks into a state similar to jobctl > > > stop. This means that tasks can be killed, ptraced (using > > > PTRACE_SEIZE*)

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-11 Thread Roman Gushchin
On Tue, Dec 11, 2018 at 05:26:32PM +0100, Oleg Nesterov wrote: > On 12/07, Roman Gushchin wrote: > > > > Cgroup v2 freezer tries to put tasks into a state similar to jobctl > > stop. This means that tasks can be killed, ptraced (using > > PTRACE_SEIZE*), and interrupted. It is possible to attach to

Re: [PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-11 Thread Oleg Nesterov
On 12/07, Roman Gushchin wrote: > > Cgroup v2 freezer tries to put tasks into a state similar to jobctl > stop. This means that tasks can be killed, ptraced (using > PTRACE_SEIZE*), and interrupted. It is possible to attach to > a frozen task, get some information (e.g. read registers) and detach.

[PATCH v5 4/7] cgroup: cgroup v2 freezer

2018-12-07 Thread Roman Gushchin
Cgroup v1 implements the freezer controller, which provides an ability to stop the workload in a cgroup and temporarily free up some resources (cpu, io, network bandwidth and, potentially, memory) for some other tasks. Cgroup v2 lacks this functionality. This patch implements freezer for cgroup v2