Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Nicolin Chen
On Thu, Sep 27, 2018 at 12:44:13PM -0500, Rob Herring wrote: > > +2) child nodes > > + Required properties: > > + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of > > INA3221 > > + > > + Optional properties: > > + - label: Name of the input source > > + - shunt-resistor-micr

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Rob Herring
On Tue, Sep 25, 2018 at 03:59:29PM -0700, Nicolin Chen wrote: > Texas Instruments INA3221 is a triple-channel shunt and bus > voltage monitor. This patch adds a DT binding doc for it. > > Signed-off-by: Nicolin Chen > --- > Changelog > v4->v5: > * Replaced "input-id" with "reg" and added address

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Rob Herring
On Tue, Sep 25, 2018 at 06:52:29PM -0700, Guenter Roeck wrote: > Hi Nicolin, > > On 09/25/2018 03:59 PM, Nicolin Chen wrote: > > Texas Instruments INA3221 is a triple-channel shunt and bus > > voltage monitor. This patch adds a DT binding doc for it. > > > > Signed-off-by: Nicolin Chen > > --- >

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Nicolin Chen
On Tue, Sep 25, 2018 at 08:40:59PM -0700, Guenter Roeck wrote: > >>>+2) child nodes > >>>+ Required properties: > >>>+ - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of > >>>INA3221 > >>>+ input@0 { > >>>+ reg = <0x0>; > >>>+ status = "disabled"; > >>saying

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Guenter Roeck
On 09/25/2018 08:08 PM, Nicolin Chen wrote: Hello Guenter, On Tue, Sep 25, 2018 at 06:52:29PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of INA3221 + + Optional properties: + - label: Name of the inpu

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Nicolin Chen
Hello Guenter, On Tue, Sep 25, 2018 at 06:52:29PM -0700, Guenter Roeck wrote: > > +2) child nodes > > + Required properties: > > + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of > > INA3221 > > + > > + Optional properties: > > + - label: Name of the input source > > + -

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Guenter Roeck
Hi Nicolin, On 09/25/2018 03:59 PM, Nicolin Chen wrote: Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v4->v5: * Replaced "input-id" with "reg" and added address-cells and size-ce

[PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Nicolin Chen
Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v4->v5: * Replaced "input-id" with "reg" and added address-cells and size-cells * Replaced "input-label" with "label" * Replaced "shun