Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-13 Thread Mukesh Ojha
On 9/12/2023 12:39 AM, Jeff Johnson wrote: On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: +/** + * qcom_minidump_region_register() - Register region in APSS Minidump table. + * @region: minidump region. + * + * Return: On success, it returns 0 and

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-13 Thread Mukesh Ojha
On 9/12/2023 3:24 PM, Krzysztof Kozlowski wrote: On 12/09/2023 11:26, Mukesh Ojha wrote: + return -EINVAL; + } + + mutex_init(&md->md_lock); + ret = qcom_apss_md_table_init(md, &mdgtoc->subsystems[MINIDUMP_APSS_DESC]); + if (ret) { + dev_

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-12 Thread Mukesh Ojha
On 9/12/2023 2:56 PM, Mukesh Ojha wrote: Thanks for your time in reviewing this. On 9/11/2023 4:31 PM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user device

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-12 Thread Krzysztof Kozlowski
On 12/09/2023 11:26, Mukesh Ojha wrote: >> >>> + return -EINVAL; >>> + } >>> + >>> + mutex_init(&md->md_lock); >>> + ret = qcom_apss_md_table_init(md, >>> &mdgtoc->subsystems[MINIDUMP_APSS_DESC]); >>> + if (ret) { >>> + dev_err(md->dev, "apss minidump initialization fai

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-12 Thread Mukesh Ojha
Thanks for your time in reviewing this. On 9/11/2023 4:31 PM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user devices running on Qualcomm SoCs. It is built on th

[REBASE PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Mukesh Ojha
Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user devices running on Qualcomm SoCs. It is built on the premise that System on Chip (SoC) or subsystem part of SoC crashes, due to a range of hardware and software bugs. Hence, the abilit

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Konrad Dybcio
On 11.09.2023 21:09, Jeff Johnson wrote: > On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: >> On 09/09/2023 22:16, Mukesh Ojha wrote: >>> +/** >>> + * qcom_minidump_region_register() - Register region in APSS Minidump >>> table. >>> + * @region: minidump region. >>> + * >>> + * Return: On success

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Krzysztof Kozlowski
On 09/09/2023 22:16, Mukesh Ojha wrote: > Minidump is a best effort mechanism to collect useful and predefined > data for first level of debugging on end user devices running on > Qualcomm SoCs. It is built on the premise that System on Chip (SoC) > or subsystem part of SoC crashes, due to a range

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Krzysztof Kozlowski
On 09/09/2023 22:16, Mukesh Ojha wrote: > +/** > + * qcom_minidump_region_register() - Register region in APSS Minidump table. > + * @region: minidump region. > + * > + * Return: On success, it returns 0 and negative error value on failure. > + */ > +int qcom_minidump_region_register(const struct q

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Jeff Johnson
On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: +/** + * qcom_minidump_region_register() - Register region in APSS Minidump table. + * @region: minidump region. + * + * Return: On success, it returns 0 and negative error value on failure. + */ +int qcom_m

Re: [REBASE PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Krzysztof Kozlowski
On 11/09/2023 12:53, Mukesh Ojha wrote: ... > +module_platform_driver(qcom_minidump_driver); > + > +MODULE_DESCRIPTION("Qualcomm APSS minidump driver"); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:qcom-minidump-smem"); Nothing improved here and in other places. To avoid review being spre

[PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-09 Thread Mukesh Ojha
Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user devices running on Qualcomm SoCs. It is built on the premise that System on Chip (SoC) or subsystem part of SoC crashes, due to a range of hardware and software bugs. Hence, the abilit