Re: [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread kbuild test robot
Hi Juergen, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc7 next-20181009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

Re: [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
On 09/10/2018 15:22, Boris Ostrovsky wrote: > On 10/9/18 6:54 AM, Juergen Gross wrote: >> + >> +u64 x86_default_get_root_pointer(void) >> +{ >> +return boot_params.hdr.acpi_rsdp_addr; >> +} > > > Should we then update init_pvh_bootparams() with > >     pvh_bootparams.hdr.acpi_rsdp_addr = pvh

Re: [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Boris Ostrovsky
On 10/9/18 6:54 AM, Juergen Gross wrote: > + > +u64 x86_default_get_root_pointer(void) > +{ > + return boot_params.hdr.acpi_rsdp_addr; > +} Should we then update init_pvh_bootparams() with     pvh_bootparams.hdr.acpi_rsdp_addr = pvh_start_info.rsdp_paddr; (and drop x86_init.acpi.get_root_po

[PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- V3: use a generic retrieval function with a __weak annotated default function (Ingo Molnar) V4: chec