Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-31 Thread Mac Xu
> On Sun, 2024-03-31 at 13:46 +, Mac Xu wrote: > > > On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote: > > > > From: Xining Xu > > > > > > > > If function-like macros do not utilize a parameter, it might result in a > > > > build warning. In our coding style guidelines, we advocate for >

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-31 Thread Joe Perches
On Sun, 2024-03-31 at 13:46 +, Mac Xu wrote: > > On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote: > > > From: Xining Xu > > > > > > If function-like macros do not utilize a parameter, it might result in a > > > build warning. In our coding style guidelines, we advocate for utilizing > >

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-31 Thread Mac Xu
> On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote: > > From: Xining Xu > > > > If function-like macros do not utilize a parameter, it might result in a > > build warning. In our coding style guidelines, we advocate for utilizing > > static inline functions to replace such macros. This patch

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-31 Thread Mac Xu
> On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote: > > From: Xining Xu > > > > If function-like macros do not utilize a parameter, it might result in a > > build warning. In our coding style guidelines, we advocate for utilizing > > static inline functions to replace such macros. This patch

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-28 Thread Barry Song
On Fri, Mar 29, 2024 at 5:01 AM Jeff Johnson wrote: > > On 3/27/2024 7:21 PM, Barry Song wrote: > > From: Xining Xu > > > > If function-like macros do not utilize a parameter, it might result in a > > build warning. In our coding style guidelines, we advocate for utilizing > > static inline func

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-28 Thread Jeff Johnson
On 3/27/2024 7:21 PM, Barry Song wrote: > From: Xining Xu > > If function-like macros do not utilize a parameter, it might result in a > build warning. In our coding style guidelines, we advocate for utilizing > static inline functions to replace such macros. This patch verifies > compliance wi

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-28 Thread Joe Perches
On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote: > From: Xining Xu > > If function-like macros do not utilize a parameter, it might result in a > build warning. In our coding style guidelines, we advocate for utilizing > static inline functions to replace such macros. This patch verifies >

[PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-27 Thread Barry Song
From: Xining Xu If function-like macros do not utilize a parameter, it might result in a build warning. In our coding style guidelines, we advocate for utilizing static inline functions to replace such macros. This patch verifies compliance with the new rule. For a macro such as the one below,