Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-14 Thread Sumit Garg
On Wed, 5 Jun 2019 at 16:39, Sumit Garg wrote: > > On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: > > > > On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: > > >On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: > > >> + /* Open context with TEE driver */ > > >> + pvt_data->

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-14 Thread Ilias Apalodimas
Hi Sasha, On Thu, Jun 13, 2019 at 01:11:41PM -0400, Sasha Levin wrote: > On Wed, Jun 05, 2019 at 04:39:36PM +0530, Sumit Garg wrote: > >On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: > >> > >>On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: > >>>On Thu, 30 May 2019 at 20:58, Sasha Lev

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-13 Thread Sasha Levin
On Wed, Jun 05, 2019 at 04:39:36PM +0530, Sumit Garg wrote: On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: >On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: >> + /* Open context with TEE driver */ >> + pvt_data->ctx = te

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-05 Thread Jarkko Sakkinen
On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: > Is this well tested? I see this misleading error multiple times as > follows although TEE driver works pretty well. > > Module built with "CONFIG_TCG_FTPM_TEE=y" > > [1.436878] ftpm-tee tpm@0: ftpm_tee_probe:tee_client_open_context

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-05 Thread Sumit Garg
On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: > > On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: > >On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: > >> + /* Open context with TEE driver */ > >> + pvt_data->ctx = tee_client_open_context(NULL, ftpm_tee_match, NULL, > >>

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-04 Thread Sasha Levin
On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: + /* Open context with TEE driver */ + pvt_data->ctx = tee_client_open_context(NULL, ftpm_tee_match, NULL, + NULL); + if (

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-03 Thread Sumit Garg
On Thu, 30 May 2019 at 20:58, Sasha Levin wrote: > > This patch adds support for a software-only implementation of a TPM > running in TEE. > > There is extensive documentation of the design here: > https://www.microsoft.com/en-us/research/publication/ftpm-software-implementation-tpm-chip/ > . > >

[PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-05-30 Thread Sasha Levin
This patch adds support for a software-only implementation of a TPM running in TEE. There is extensive documentation of the design here: https://www.microsoft.com/en-us/research/publication/ftpm-software-implementation-tpm-chip/ . As well as reference code for the firmware available here: https: