Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-23 Thread Nicolin Chen
On Sat, Sep 22, 2018 at 11:36:22PM -0700, Guenter Roeck wrote: > >+ Optional properties: > >+ - input-label: Name of the input source > > Just noticed the "input-" here. Please just use "label". Will fix in v5. > >+ input1 { > >+ input-id = <0x1>; > > We'll h

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 11:01 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:45:49PM -0700, Guenter Roeck wrote: On 09/22/2018 10:31 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - input-id: Must be 1, 2 or 3 + + Op

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Nicolin Chen
On Sat, Sep 22, 2018 at 10:45:49PM -0700, Guenter Roeck wrote: > On 09/22/2018 10:31 PM, Nicolin Chen wrote: > > On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: > > > > +2) child nodes > > > > + Required properties: > > > > + - input-id: Must be 1, 2 or 3 > > > > + > > > > + Optio

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 10:31 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - input-id: Must be 1, 2 or 3 + + Optional properties: + - input-label: Name of the input source + - shunt-resistor: Shunt resistor value in mi

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Nicolin Chen
On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: > >+2) child nodes > >+ Required properties: > >+ - input-id: Must be 1, 2 or 3 > >+ > >+ Optional properties: > >+ - input-label: Name of the input source > >+ - shunt-resistor: Shunt resistor value in micro-Ohm > >+ - status: Sh

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 09:11 PM, Nicolin Chen wrote: Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v3->v4: * Removed the attempt of putting labels in the node names * Added a new optiona

[PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Nicolin Chen
Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v3->v4: * Removed the attempt of putting labels in the node names * Added a new optional label property in the child node * Updated ex