Re: [PATCH v3 3/5] dax: use common 4k zero page for dax mmap reads

2017-07-20 Thread Ross Zwisler
On Thu, Jul 20, 2017 at 12:27:23PM +0200, Jan Kara wrote: > On Wed 19-07-17 10:26:45, Ross Zwisler wrote: > > On Wed, Jul 19, 2017 at 05:33:14PM +0200, Jan Kara wrote: > > > On Wed 28-06-17 16:01:50, Ross Zwisler wrote: > > > > Another major change is that we remove dax_pfn_mkwrite() from our fault

Re: [PATCH v3 3/5] dax: use common 4k zero page for dax mmap reads

2017-07-20 Thread Jan Kara
On Wed 19-07-17 10:26:45, Ross Zwisler wrote: > On Wed, Jul 19, 2017 at 05:33:14PM +0200, Jan Kara wrote: > > On Wed 28-06-17 16:01:50, Ross Zwisler wrote: > > > Another major change is that we remove dax_pfn_mkwrite() from our fault > > > flow, and instead rely on the page fault itself to make the

Re: [PATCH v3 3/5] dax: use common 4k zero page for dax mmap reads

2017-07-19 Thread Ross Zwisler
On Wed, Jul 19, 2017 at 05:33:14PM +0200, Jan Kara wrote: > On Wed 28-06-17 16:01:50, Ross Zwisler wrote: > > Another major change is that we remove dax_pfn_mkwrite() from our fault > > flow, and instead rely on the page fault itself to make the PTE dirty and > > writeable. The following descripti

Re: [PATCH v3 3/5] dax: use common 4k zero page for dax mmap reads

2017-07-19 Thread Jan Kara
On Wed 28-06-17 16:01:50, Ross Zwisler wrote: > Another major change is that we remove dax_pfn_mkwrite() from our fault > flow, and instead rely on the page fault itself to make the PTE dirty and > writeable. The following description from the patch adding the > vm_insert_mixed_mkwrite() call expl

[PATCH v3 3/5] dax: use common 4k zero page for dax mmap reads

2017-06-28 Thread Ross Zwisler
When servicing mmap() reads from file holes the current DAX code allocates a page cache page of all zeroes and places the struct page pointer in the mapping->page_tree radix tree. This has three major drawbacks: 1) It consumes memory unnecessarily. For every 4k page that is read via a DAX mmap()