Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-24 Thread Jae Hyun Yoo
On 4/24/2018 9:01 AM, Andy Shevchenko wrote: On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus core into linux driver framework. All comments you got for patch 6 are applicable here. And perhaps in the rest of the series. The rule of

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-24 Thread Andy Shevchenko
On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus core into linux > driver framework. > All comments you got for patch 6 are applicable here. And perhaps in the rest of the series. The rule of thumb: when you get even single comment in

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-23 Thread Jae Hyun Yoo
On 4/23/2018 3:52 AM, Greg KH wrote: On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote: +static void peci_adapter_dev_release(struct device *dev) +{ + /* do nothing */ +} As per the in-kernel documentation, I am now allowed to make fun of you. You are trying to "out smart" th

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-23 Thread Greg KH
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote: > +static void peci_adapter_dev_release(struct device *dev) > +{ > + /* do nothing */ > +} As per the in-kernel documentation, I am now allowed to make fun of you. You are trying to "out smart" the kernel by getting rid of a warnin

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-19 Thread kbuild test robot
Hi Jae, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc1 next-20180419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

[PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-10 Thread Jae Hyun Yoo
This commit adds driver implementation for PECI bus core into linux driver framework. Signed-off-by: Jae Hyun Yoo Signed-off-by: Fengguang Wu Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc