Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Randy Dunlap
On 12/14/2017 12:44 PM, Boris Brezillon wrote: > On Thu, 14 Dec 2017 12:25:14 -0800 > Randy Dunlap wrote: > >> On 12/14/2017 12:17 PM, Boris Brezillon wrote: > + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; > + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events); > +

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Boris Brezillon
On Thu, 14 Dec 2017 12:25:14 -0800 Randy Dunlap wrote: > On 12/14/2017 12:17 PM, Boris Brezillon wrote: > >>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; > >>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events); > >>> + if (ret) > >>> + pr_info("Failed to re-enable

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Randy Dunlap
On 12/14/2017 12:17 PM, Boris Brezillon wrote: >>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; >>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events); >>> + if (ret) >>> + pr_info("Failed to re-enable H-J"); >> Not very good info... > What do yo

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Boris Brezillon
Hi Randy, On Thu, 14 Dec 2017 11:54:16 -0800 Randy Dunlap wrote: > On 12/14/2017 07:16 AM, Boris Brezillon wrote: > > Add a driver for Cadence I3C master IP. > > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v2: > > - Add basic IBI support. Note that the IP is not really reliable w

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Randy Dunlap
On 12/14/2017 07:16 AM, Boris Brezillon wrote: > Add a driver for Cadence I3C master IP. > > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Add basic IBI support. Note that the IP is not really reliable with > regards to IBI because you can't extract IBI payloads as soon as you > h

[PATCH v2 6/7] i3c: master: Add driver for Cadence IP

2017-12-14 Thread Boris Brezillon
Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon --- Changes in v2: - Add basic IBI support. Note that the IP is not really reliable with regards to IBI because you can't extract IBI payloads as soon as you have more than one IBI waiting in the HW queue. This is somethin