Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-10 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2025/01/10 17:33, Michael S. Tsirkin wrote: > > On Fri, Jan 10, 2025 at 01:38:06PM +0900, Akihiko Odaki wrote: > >> On 2025/01/09 21:46, Willem de Bruijn wrote: > >>> Akihiko Odaki wrote: > On 2025/01/09 16:31, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2025 at

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 17:33, Michael S. Tsirkin wrote: On Fri, Jan 10, 2025 at 01:38:06PM +0900, Akihiko Odaki wrote: On 2025/01/09 21:46, Willem de Bruijn wrote: Akihiko Odaki wrote: On 2025/01/09 16:31, Michael S. Tsirkin wrote: On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: tun us

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 12:27, Jason Wang wrote: On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote: tun used to simply advance iov_iter when it needs to pad virtio header, which leaves the garbage in the buffer as is. This is especially problematic when tun starts to allow enabling the hash reporting f

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-10 Thread Michael S. Tsirkin
On Fri, Jan 10, 2025 at 01:38:06PM +0900, Akihiko Odaki wrote: > On 2025/01/09 21:46, Willem de Bruijn wrote: > > Akihiko Odaki wrote: > > > On 2025/01/09 16:31, Michael S. Tsirkin wrote: > > > > On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > > > > > tun used to simply advance iov

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-09 Thread Akihiko Odaki
On 2025/01/09 21:46, Willem de Bruijn wrote: Akihiko Odaki wrote: On 2025/01/09 16:31, Michael S. Tsirkin wrote: On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: tun used to simply advance iov_iter when it needs to pad virtio header, which leaves the garbage in the buffer as is.

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-09 Thread Jason Wang
On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote: > > tun used to simply advance iov_iter when it needs to pad virtio header, > which leaves the garbage in the buffer as is. This is especially > problematic when tun starts to allow enabling the hash reporting > feature; even if the feature is en

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-09 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2025/01/09 16:31, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > >> tun used to simply advance iov_iter when it needs to pad virtio header, > >> which leaves the garbage in the buffer as is. This is especially > >> problemati

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-09 Thread Jan Kara
On Thu 09-01-25 18:36:52, Akihiko Odaki wrote: > On 2025/01/09 16:43, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2025 at 04:41:50PM +0900, Akihiko Odaki wrote: > > > On 2025/01/09 16:31, Michael S. Tsirkin wrote: > > > > On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > > > > > tu

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-09 Thread Akihiko Odaki
On 2025/01/09 16:43, Michael S. Tsirkin wrote: On Thu, Jan 09, 2025 at 04:41:50PM +0900, Akihiko Odaki wrote: On 2025/01/09 16:31, Michael S. Tsirkin wrote: On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: tun used to simply advance iov_iter when it needs to pad virtio header, wh

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-08 Thread Michael S. Tsirkin
On Thu, Jan 09, 2025 at 04:41:50PM +0900, Akihiko Odaki wrote: > On 2025/01/09 16:31, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > > > tun used to simply advance iov_iter when it needs to pad virtio header, > > > which leaves the garbage in the buff

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-08 Thread Michael S. Tsirkin
On Thu, Jan 09, 2025 at 02:31:37AM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > > tun used to simply advance iov_iter when it needs to pad virtio header, > > which leaves the garbage in the buffer as is. This is especially > > problematic when

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-08 Thread Akihiko Odaki
On 2025/01/09 16:31, Michael S. Tsirkin wrote: On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: tun used to simply advance iov_iter when it needs to pad virtio header, which leaves the garbage in the buffer as is. This is especially problematic when tun starts to allow enabling the

Re: [PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-08 Thread Michael S. Tsirkin
On Thu, Jan 09, 2025 at 03:58:44PM +0900, Akihiko Odaki wrote: > tun used to simply advance iov_iter when it needs to pad virtio header, > which leaves the garbage in the buffer as is. This is especially > problematic when tun starts to allow enabling the hash reporting > feature; even if the featu

[PATCH v2 2/3] tun: Pad virtio header with zero

2025-01-08 Thread Akihiko Odaki
tun used to simply advance iov_iter when it needs to pad virtio header, which leaves the garbage in the buffer as is. This is especially problematic when tun starts to allow enabling the hash reporting feature; even if the feature is enabled, the packet may lack a hash value and may contain a hole