Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-10-02 Thread Daniel Kiper
On Tue, Oct 01, 2019 at 03:28:01PM -0700, H. Peter Anvin wrote: > On 2019-10-01 04:41, Daniel Kiper wrote: > > > > OK, so, this is more or less what I had in my v3 patch before sending > > this email. So, it looks that I am on good track. Great! Though I am not > > sure that we should have magic fo

Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-10-01 Thread H. Peter Anvin
On 2019-10-01 04:41, Daniel Kiper wrote: > > OK, so, this is more or less what I had in my v3 patch before sending > this email. So, it looks that I am on good track. Great! Though I am not > sure that we should have magic for chunked objects. If yes could you > explain why? I would just leave len

Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-10-01 Thread Daniel Kiper
On Mon, Sep 30, 2019 at 10:18:43AM -0700, H. Peter Anvin wrote: > On 2019-09-30 08:01, Daniel Kiper wrote: > > > > OK. > > > >> field for the entire .kernel_info section, thus ensuring it is a > >> single self-contained blob. > > > > .rodata.kernel_info contains its total size immediately behind th

Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-09-30 Thread H. Peter Anvin
On 2019-09-30 08:01, Daniel Kiper wrote: > > OK. > >> field for the entire .kernel_info section, thus ensuring it is a >> single self-contained blob. > > .rodata.kernel_info contains its total size immediately behind the > "InfO" header. Do you suggest that we should add the size of > .rodata.ke

Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-09-30 Thread Daniel Kiper
On Fri, Jul 12, 2019 at 09:04:23AM -0700, h...@zytor.com wrote: > On July 4, 2019 9:36:10 AM PDT, Daniel Kiper wrote: > >The relationships between the headers are analogous to the various data > >sections: > > > > setup_header = .data > > boot_params/setup_data = .bss > > > >What is missing from

Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-07-12 Thread hpa
On July 4, 2019 9:36:10 AM PDT, Daniel Kiper wrote: >The relationships between the headers are analogous to the various data >sections: > > setup_header = .data > boot_params/setup_data = .bss > >What is missing from the above list? That's right: > > kernel_info = .rodata > >We have been (ab)us

[PATCH v2 1/3] x86/boot: Introduce the kernel_info

2019-07-04 Thread Daniel Kiper
The relationships between the headers are analogous to the various data sections: setup_header = .data boot_params/setup_data = .bss What is missing from the above list? That's right: kernel_info = .rodata We have been (ab)using .data for things that could go into .rodata or .bss for a lo