Re: [PATCH v2] Ext4 documentation fixes.

2019-08-25 Thread Jonathan Corbet
On Sat, 24 Aug 2019 19:09:30 -0400 "Theodore Y. Ts'o" wrote: > If you haven't pushed out your doc tree, can you please drop it? I've > already applied an (improved) version of this patch to the ext4 tree, > and I actually have some plans to do further fixups of ext4 on-disk > format documentatio

Re: [PATCH v2] Ext4 documentation fixes.

2019-08-24 Thread Theodore Y. Ts'o
On Sat, Aug 24, 2019 at 03:24:53PM -0600, Jonathan Corbet wrote: > I've applied this to the docs tree. > > However, Ayush: the patch was rather badly corrupted by your mail client. > I managed to fix it up, but please in the future verify that you can email > a patch to yourself and apply it befor

Re: [PATCH v2] Ext4 documentation fixes.

2019-08-24 Thread Jonathan Corbet
On Thu, 15 Aug 2019 09:16:23 -0700 Andreas Dilger wrote: > On Aug 15, 2019, at 09:11, Ayush Ranjan wrote: > > > > This commit aims to fix the following issues in ext4 documentation: > > - Flexible block group docs said that the aim was to group block > > metadata together instead of block gro

Re: [PATCH v2] Ext4 documentation fixes.

2019-08-23 Thread Theodore Y. Ts'o
On Fri, Aug 23, 2019 at 04:56:42AM +, Ayush Ranjan wrote: > Hey Ted! > Thanks for reviewing! The comment in > fs/ext4/ext4.h:ext4_group_desc:bg_checksum > says that the crc16 checksum formula should be crc16(sb_uuid+group+desc). I > think group over here denotes group number. > > Briefly look

Re: [PATCH v2] Ext4 documentation fixes.

2019-08-22 Thread Theodore Y. Ts'o
On Thu, Aug 15, 2019 at 09:11:51AM -0700, Ayush Ranjan wrote: > This commit aims to fix the following issues in ext4 documentation: > - Flexible block group docs said that the aim was to group block > metadata together instead of block group metadata. > - The documentation consistly uses "locatio