Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-27 Thread atull
On Mon, 25 Jan 2016, Rob Herring wrote: > On Fri, Jan 22, 2016 at 6:07 PM, Moritz Fischer > wrote: > > On Fri, Jan 22, 2016 at 5:37 PM, atull wrote: > >> On Fri, 22 Jan 2016, Moritz Fischer wrote: > >> > >>> Alan, > >>> > >>> On Wed, Jan 20, 2016 at 8:24 PM, wrote: > >>> > >>> > +static int fp

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-25 Thread Rob Herring
On Fri, Jan 22, 2016 at 6:07 PM, Moritz Fischer wrote: > On Fri, Jan 22, 2016 at 5:37 PM, atull wrote: >> On Fri, 22 Jan 2016, Moritz Fischer wrote: >> >>> Alan, >>> >>> On Wed, Jan 20, 2016 at 8:24 PM, wrote: >>> >>> > +static int fpga_area_probe(struct platform_device *pdev) >>> > +{ >>> > +

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-22 Thread Moritz Fischer
On Fri, Jan 22, 2016 at 5:37 PM, atull wrote: > On Fri, 22 Jan 2016, Moritz Fischer wrote: > >> Alan, >> >> On Wed, Jan 20, 2016 at 8:24 PM, wrote: >> >> > +static int fpga_area_probe(struct platform_device *pdev) >> > +{ >> > + struct device *dev = &pdev->dev; >> > + struct device_n

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-22 Thread atull
On Fri, 22 Jan 2016, Moritz Fischer wrote: > Alan, > > On Wed, Jan 20, 2016 at 8:24 PM, wrote: > > > +static int fpga_area_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev->of_node; > > + struct fpga_area *ar

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-22 Thread Moritz Fischer
Alan, On Wed, Jan 20, 2016 at 8:24 PM, wrote: > +static int fpga_area_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + struct fpga_area *area; > + int ret; > + > + area = devm_kzalloc(dev,

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-21 Thread atull
On Thu, 21 Jan 2016, Moritz Fischer wrote: > Hi Alan, > > minor nits inline: > > On Wed, Jan 20, 2016 at 8:24 PM, wrote: > > > v15: Add altr,fpga-bus implementation > > Change compatible string "fpga-area" -> "altr,fpga-area" > > Doesn't look that way down there. Or am I reading the cod

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-21 Thread Moritz Fischer
Hi Alan, minor nits inline: On Wed, Jan 20, 2016 at 8:24 PM, wrote: > v15: Add altr,fpga-bus implementation > Change compatible string "fpga-area" -> "altr,fpga-area" Doesn't look that way down there. Or am I reading the code wrong? > +static const struct of_device_id fpga_area_of_match

[PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

2016-01-20 Thread atull
From: Alan Tull FPGA Area and FPGA Bus support programming FPGA under control of the Device Tree. A FPGA Bus contains the devices necessary for programming an FPGA. When a Device Tree Overlay containing a FPGA Area is applied, the FPGA Area will be probed and will: * check to see if there is a