Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-13 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 09:20:40PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 08, 2018 at 04:39:42PM +0200, Jarkko Sakkinen wrote: > > On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > > > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > > > >> Does this code run when I type "make kselfte

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-08 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 04:39:42PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > > >> Does this code run when I type "make kselftest"? If not, I think we > > >> should rectify that. > > > No, it doesn't

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-08 Thread Jarkko Sakkinen
On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > >> Does this code run when I type "make kselftest"? If not, I think we > >> should rectify that. > > No, it doesn't. It is just my backup for the non-SDK user space code > > that I've made t

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-07 Thread Dave Hansen
On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: >> Does this code run when I type "make kselftest"? If not, I think we >> should rectify that. > No, it doesn't. It is just my backup for the non-SDK user space code > that I've made that I will use to fork my user space SGX projects in > the future. > >

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-07 Thread Jarkko Sakkinen
On Tue, Nov 06, 2018 at 08:45:37AM -0800, Dave Hansen wrote: > On 11/5/18 9:49 PM, Jarkko Sakkinen wrote: > > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > >> The ABI seems entirely undocumented and rather lightly designed, which > >> seems like something we should fix before this

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-06 Thread Dave Hansen
On 11/5/18 9:49 PM, Jarkko Sakkinen wrote: > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: >> The ABI seems entirely undocumented and rather lightly designed, which >> seems like something we should fix before this is merged. > > ABI is documented in arch/x86/include/uapi/asm/sgx.h

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > This patch set establishes an ABI. It basically sets in stone a bunch > of behaviors that the enclave, the kernel, and the out-of-enclave code > must follow. > > There are a bunch of things that the enclave can do to %rsp or %rip, for

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-05 Thread Jarkko Sakkinen
On Tue, Nov 06, 2018 at 07:49:11AM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > > The ABI seems entirely undocumented and rather lightly designed, which > > seems like something we should fix before this is merged. > > ABI is documented in arch/x86

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > The ABI seems entirely undocumented and rather lightly designed, which > seems like something we should fix before this is merged. ABI is documented in arch/x86/include/uapi/asm/sgx.h that from which the documentation is included to in

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-05 Thread Dave Hansen
On 11/2/18 4:11 PM, Jarkko Sakkinen wrote: > Documentation/index.rst | 1 + > Documentation/x86/intel_sgx.rst | 185 > 2 files changed, 186 insertions(+) > create mode 100644 Documentation/x86/intel_sgx.rst This patch set establishes an ABI. It basical

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-05 Thread Jarkko Sakkinen
On Sun, Nov 04, 2018 at 10:15:13AM +0200, Mike Rapoport wrote: > On Sat, Nov 03, 2018 at 01:11:22AM +0200, Jarkko Sakkinen wrote: > > Documentation of the features of the Software Guard eXtensions used > > by the Linux kernel and basic design choices for the core and driver > > and functionality. >

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-04 Thread Mike Rapoport
On Sat, Nov 03, 2018 at 01:11:22AM +0200, Jarkko Sakkinen wrote: > Documentation of the features of the Software Guard eXtensions used > by the Linux kernel and basic design choices for the core and driver > and functionality. > > Signed-off-by: Jarkko Sakkinen > --- > Documentation/index.rst

[PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-02 Thread Jarkko Sakkinen
Documentation of the features of the Software Guard eXtensions used by the Linux kernel and basic design choices for the core and driver and functionality. Signed-off-by: Jarkko Sakkinen --- Documentation/index.rst | 1 + Documentation/x86/intel_sgx.rst | 185 ++