Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-16 Thread Suravee Suthikulpanit
Tested-by: Suravee Suthikulpanit Thanks, Suravee On 02/10/2016 12:00 AM, fu@linaro.org wrote: From: Fu Wei According to Server Base System Architecture (SBSA) specification, the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) is for alerting the system by interrupt,

Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-10 Thread Mathieu Poirier
On 9 February 2016 at 10:00, wrote: > From: Fu Wei > > According to Server Base System Architecture (SBSA) specification, > the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) > is for alerting the system by interrupt, the second one (WS1) is a real > hardware reset. > More

Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-09 Thread Fu Wei
Hi Timur, On 10 February 2016 at 01:39, Timur Tabi wrote: > fu@linaro.org wrote: > >> + if (!action) >> + dev_warn(dev, "fall back to signle stage >> mode.\n"); > > > "falling back to single stage mode" Thanks for your correction. :-) Will fixed it > > A

Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-09 Thread Timur Tabi
fu@linaro.org wrote: + if (!action) + dev_warn(dev, "fall back to signle stage mode.\n"); "falling back to single stage mode" Acked-by: Timur Tabi The whole "calculate the timeouts different if 'action' is enabled" seems clunky to me, but I can't thi

[PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-09 Thread fu . wei
From: Fu Wei According to Server Base System Architecture (SBSA) specification, the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) is for alerting the system by interrupt, the second one (WS1) is a real hardware reset. More details about the hardware specification of this de