Re: [PATCH v10 4/5] overlayfs: internal getxattr operations without sepolicy checking

2019-07-25 Thread Amir Goldstein
On Thu, Jul 25, 2019 at 5:37 PM Mark Salyzyn wrote: > > Thanks for the review. > > On 7/25/19 4:00 AM, Amir Goldstein wrote: > > On Wed, Jul 24, 2019 at 10:57 PM Mark Salyzyn wrote: > >> Check impure, opaque, origin & meta xattr with no sepolicy audit > >> (using __vfs_getxattr) since these opera

Re: [PATCH v10 4/5] overlayfs: internal getxattr operations without sepolicy checking

2019-07-25 Thread Mark Salyzyn
Thanks for the review. On 7/25/19 4:00 AM, Amir Goldstein wrote: On Wed, Jul 24, 2019 at 10:57 PM Mark Salyzyn wrote: Check impure, opaque, origin & meta xattr with no sepolicy audit (using __vfs_getxattr) since these operations are internal to overlayfs operations and do not disclose any data

Re: [PATCH v10 4/5] overlayfs: internal getxattr operations without sepolicy checking

2019-07-25 Thread Amir Goldstein
On Wed, Jul 24, 2019 at 10:57 PM Mark Salyzyn wrote: > > Check impure, opaque, origin & meta xattr with no sepolicy audit > (using __vfs_getxattr) since these operations are internal to > overlayfs operations and do not disclose any data. This became > an issue for credential override off since s

[PATCH v10 4/5] overlayfs: internal getxattr operations without sepolicy checking

2019-07-24 Thread Mark Salyzyn
Check impure, opaque, origin & meta xattr with no sepolicy audit (using __vfs_getxattr) since these operations are internal to overlayfs operations and do not disclose any data. This became an issue for credential override off since sys_admin would have been required by the caller; whereas would h