Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-26 Thread Luc Van Oostenryck
On Tue, Feb 26, 2019 at 06:18:25PM +0100, Andrey Konovalov wrote: > On Fri, Feb 22, 2019 at 11:55 PM Dave Hansen wrote: > > > > On 2/22/19 4:53 AM, Andrey Konovalov wrote: > > > The following testing approaches has been taken to find potential issues > > > with user pointer untagging: > > > > > >

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-26 Thread Dave Hansen
On 2/26/19 9:18 AM, Andrey Konovalov wrote: >> This seems like something >> where we would ideally add an __tagged annotation (or something) to the >> source tree and then have sparse rules that can look for missed untags. > This has been suggested before, search for __untagged here [1]. > However

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-26 Thread Andrey Konovalov
On Fri, Feb 22, 2019 at 11:55 PM Dave Hansen wrote: > > On 2/22/19 4:53 AM, Andrey Konovalov wrote: > > The following testing approaches has been taken to find potential issues > > with user pointer untagging: > > > > 1. Static testing (with sparse [3] and separately with a custom static > >an

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-26 Thread Andrey Konovalov
On Fri, Feb 22, 2019 at 5:10 PM Szabolcs Nagy wrote: > > On 22/02/2019 15:40, Andrey Konovalov wrote: > > On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: > >> > >> On 22/02/2019 12:53, Andrey Konovalov wrote: > >>> This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. >

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Dave Hansen
On 2/22/19 4:53 AM, Andrey Konovalov wrote: > The following testing approaches has been taken to find potential issues > with user pointer untagging: > > 1. Static testing (with sparse [3] and separately with a custom static >analyzer based on Clang) to track casts of __user pointers to intege

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 15:40, Andrey Konovalov wrote: > On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: >> >> On 22/02/2019 12:53, Andrey Konovalov wrote: >>> This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. >>> >>> arm64 has a feature called Top Byte Ignore, which allows to

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Andrey Konovalov
On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: > > On 22/02/2019 12:53, Andrey Konovalov wrote: > > This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. > > > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > > tags into the top byte of each

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 12:53, Andrey Konovalov wrote: > This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > tags into the top byte of each pointer. Userspace programs (such as > HWASan, a memory debugging

[PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Andrey Konovalov
This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [2]) might use this feature and pass tagged user