On 2/12/2025 9:58 AM, Jie Gan wrote:
+static int qcom_ppe_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct ppe_device *ppe_dev;
+ void __iomem *base;
+ int ret, num_icc;
I think it's better with:
int num_icc = ARRAY_SIZE(ppe_icc_data);
This
On 2/11/2025 9:58 PM, Jie Luo wrote:
On 2/10/2025 10:12 AM, Jie Gan wrote:
+static int ppe_clock_init_and_reset(struct ppe_device *ppe_dev)
+{
+ unsigned long ppe_rate = ppe_dev->clk_rate;
+ struct device *dev = ppe_dev->dev;
+ struct reset_control *rstc;
+ struct clk_bulk_data
On 2/11/2025 9:04 PM, Andrew Lunn wrote:
+#ifndef __PPE_H__
+#define __PPE_H__
+
+#include
+#include
+
+struct device;
#include ?
+struct regmap;
Same with previous one, include it's header file?
If the structure is opaque at this level, it is fine to not include
the header. There is
On 2/10/2025 10:12 AM, Jie Gan wrote:
+static int ppe_clock_init_and_reset(struct ppe_device *ppe_dev)
+{
+ unsigned long ppe_rate = ppe_dev->clk_rate;
+ struct device *dev = ppe_dev->dev;
+ struct reset_control *rstc;
+ struct clk_bulk_data *clks;
+ struct clk *clk;
+ int re
> > +#ifndef __PPE_H__
> > +#define __PPE_H__
> > +
> > +#include
> > +#include
> > +
> > +struct device;
> #include ?
>
> > +struct regmap;
> Same with previous one, include it's header file?
>
If the structure is opaque at this level, it is fine to not include
the header. There is nothing i
On 2/9/2025 10:29 PM, Luo Jie wrote:
The PPE (Packet Process Engine) hardware block is available
on Qualcomm IPQ SoC that support PPE architecture, such as
IPQ9574.
The PPE in IPQ9574 includes six integrated ethernet MAC
(for 6 PPE ports), buffer management, queue management and
scheduler fun
The PPE (Packet Process Engine) hardware block is available
on Qualcomm IPQ SoC that support PPE architecture, such as
IPQ9574.
The PPE in IPQ9574 includes six integrated ethernet MAC
(for 6 PPE ports), buffer management, queue management and
scheduler functions. The MACs can connect with the exte
