Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Dmitry Safonov
On Wed, 5 Jun 2024 at 18:37, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454...@gmail.com> wrote: > > > > Hi Eric, > > > > Thanks for the review, > > > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: [..] > > > Then we probably do not need EXPORT_SYMBOL(tcp_inbou

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454...@gmail.com> wrote: > > Hi Eric, > > Thanks for the review, > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: > > > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > > wrote: > > > > > > From: Dmitry Safonov <0x7f454...@gmail

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Dmitry Safonov
Hi Eric, Thanks for the review, On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > wrote: > > > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > Two reasons: > > 1. It's grown up enough > > 2. In order to not do header spaghett

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-05 Thread Eric Dumazet
On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov <0x7f4

[PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-04 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp.h | 65 --