Re: [PATCH net-next v2] tun: Pad virtio headers

2025-02-20 Thread Jason Wang
On Thu, Feb 20, 2025 at 4:45 PM Michael S. Tsirkin wrote: > > On Thu, Feb 20, 2025 at 08:58:38AM +0100, Paolo Abeni wrote: > > Hi, > > > > On 2/15/25 7:04 AM, Akihiko Odaki wrote: > > > tun simply advances iov_iter when it needs to pad virtio header, > > > which leaves the garbage in the buffer as

Re: [PATCH net-next v2] tun: Pad virtio headers

2025-02-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sat, 15 Feb 2025 15:04:50 +0900 you wrote: > tun simply advances iov_iter when it needs to pad virtio header, > which leaves the garbage in the buffer as is. This will become > especially problematic when tun start

Re: [PATCH net-next v2] tun: Pad virtio headers

2025-02-20 Thread Michael S. Tsirkin
On Thu, Feb 20, 2025 at 08:58:38AM +0100, Paolo Abeni wrote: > Hi, > > On 2/15/25 7:04 AM, Akihiko Odaki wrote: > > tun simply advances iov_iter when it needs to pad virtio header, > > which leaves the garbage in the buffer as is. This will become > > especially problematic when tun starts to allo

Re: [PATCH net-next v2] tun: Pad virtio headers

2025-02-19 Thread Paolo Abeni
Hi, On 2/15/25 7:04 AM, Akihiko Odaki wrote: > tun simply advances iov_iter when it needs to pad virtio header, > which leaves the garbage in the buffer as is. This will become > especially problematic when tun starts to allow enabling the hash > reporting feature; even if the feature is enabled,

[PATCH net-next v2] tun: Pad virtio headers

2025-02-14 Thread Akihiko Odaki
tun simply advances iov_iter when it needs to pad virtio header, which leaves the garbage in the buffer as is. This will become especially problematic when tun starts to allow enabling the hash reporting feature; even if the feature is enabled, the packet may lack a hash value and may contain a hol